Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed baseName error in PHP #629

Merged
merged 1 commit into from
Jan 10, 2025
Merged

chore: fixed baseName error in PHP #629

merged 1 commit into from
Jan 10, 2025

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Jan 8, 2025

Fixes

Removing overwriting of baseName in PHP to process response model correctly

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-php from our OpenAPI specification and inspect the diff
    • Run make test in twilio-php
    • Create a pull request in twilio-php
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link

sonarqubecloud bot commented Jan 8, 2025

@tiwarishubham635
Copy link
Contributor Author

PHP changes to preview - twilio/twilio-php#838

@tiwarishubham635 tiwarishubham635 merged commit b3764c1 into main Jan 10, 2025
17 of 21 checks passed
@tiwarishubham635 tiwarishubham635 deleted the fix_php_error branch January 10, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants