Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13 The initial position set for burst #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MKG26
Copy link

@MKG26 MKG26 commented May 5, 2024

#13

@twostraws
Copy link
Owner

Thank you! I'm a bit confused: the initial position works great for me with the current code, on both macOS and iOS. Is there somewhere specific that shows the problem you're trying to fix?

@MKG26
Copy link
Author

MKG26 commented May 9, 2024

To set an initial position for the burst effect in your ConfettiView, possibly due to issues with accessing the proxy. To solve this, I suggest moving the .onAppear modifier to the outer VortexViewReader, ensuring that the initial position is calculated correctly based on the proxy size. By making this adjustment, I can ensure that the burst effect occurs at the desired location when the view is first displayed to the user.

@twostraws
Copy link
Owner

Sorry, perhaps I'm not being terribly clear. You're modifying the sandbox app. Right now the sandbox app seems to work with confetti just fine, no matter where the user first taps. Unless there is a very different bug at play, there is no confetti when the user first sees the view – it's created when they tap, at which point the position is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants