feat: add notifications UI #1
Conversation
|
@rndquu could you please increase the auth token expiry date in supabase? |
|
@zugdev pull tag here |
|
@zugdev @gentlementlegen @rndquu @whilefoo can you guys prioritize finishing this |
There was a problem hiding this comment.
Please remove the commented code
There was a problem hiding this comment.
Maybe it would be more proper to add the data into separate JSON files and mark is as generated through linguist, because the code can barely be viewed (is it actually code or just data)?
There was a problem hiding this comment.
This is data 0x4007 sent to me, it was super helpful cause my inbox was empty. I though I'd leave it, cause it might help development in the future.
src/home/home.ts
Outdated
| console.log(err); | ||
| }); | ||
| } | ||
| // if ("serviceWorker" in navigator) { |
There was a problem hiding this comment.
Did you move the PWA capabilities or forgot to un-comment it?
There was a problem hiding this comment.
forgot, thanks for the catch
|
It seems that the |
Co-authored-by: Mentlegen <[email protected]>
|
fixed all, I suppose. @gentlementlegen, I've had problems with yarn.lock in the past, if it still doesnt look right, would you mind going in and generating for me? |
|
@zugdev lock file look fine now, cypress test ran (but some tests failed). Lemme me check again the code and the responsive and I'll approve this. Responsive and code are resolved. How do I get notifications to appear? It was always empty when I tested it. |
There is some filtering done. It has to be an issue in a valid Ubiquity org, it's gotta have a price tag and an assignee. The notification reason has to be something involving a comment which can't be from a bot. Notice there is a toggle for bot notifications. 
|
|
No luck with show / hide bot button either, but since it seems to work for you and @0x4007 I trust you. |
If you open your console it should tell you why your notifs have been filtered: notif 1 filtered because not in org hopefully that helps |
|
Yes thank you, it seems that the only notifications I have come from my dummy organization, and I have none in ubq repos. What are the notifications from exactly? |
GitHub has an API endpoint to load your notifications. |
|
Yeah this project is a ubiquity specialized GitHub inbox basically. We filter a lot and order by priorities, the goal is to ensure proper prioritization. |
These rely on our special labels, specifically the priority labels. |
|
|
|
Not sure how GitHub notifications work but here is what I have as well But then I saw the logs So it seems to make sense. Notifications are only the unread ones (the ones highlighted in your GitHub notifications). |
Resolves ubiquity-os/.github#1