Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initialize #3

Open
wants to merge 49 commits into
base: development
Choose a base branch
from

Conversation

kingsley-einstein
Copy link

Resolves #1

.eslintrc Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 26, 2024

Unused exports (1)

Filename exports
src/scripts/shared.ts localhostClient

src/scripts/constants.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@kingsley-einstein kingsley-einstein marked this pull request as ready for review October 26, 2024 05:19
src/scripts/mint.ts Outdated Show resolved Hide resolved
src/scripts/redeem.ts Outdated Show resolved Hide resolved
@0x4007 0x4007 requested a review from rndquu October 27, 2024 12:57
@kingsley-einstein
Copy link
Author

@0x4007 I just realized that I was previously unassigned from this task. I already raised a PR.

@kingsley-einstein
Copy link
Author

@zugdev
The requested updates have been implemented. @rndquu agreed that it was okay to use Tailwind.

@kingsley-einstein
Copy link
Author

@zugdev The requested updates have been implemented. @rndquu agreed that it was okay to use Tailwind.

@zugdev

@zugdev
Copy link

zugdev commented Jan 4, 2025

@zugdev The requested updates have been implemented. @rndquu agreed that it was okay to use Tailwind.

@zugdev

will review soon

@zugdev
Copy link

zugdev commented Jan 8, 2025

minting works now, but you've blocked slippage inputs totally, by gray out I dont mean block, just change the style. it looks good now, but please allow user to input slippage

@kingsley-einstein
Copy link
Author

@zugdev
Updates made

@kingsley-einstein
Copy link
Author

@zugdev

Copy link

ubiquity-os bot commented Jan 21, 2025

@kingsley-einstein, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot marked this pull request as draft January 21, 2025 03:32
@kingsley-einstein kingsley-einstein marked this pull request as ready for review January 21, 2025 07:02
@kingsley-einstein
Copy link
Author

@zugdev

2 similar comments
@kingsley-einstein
Copy link
Author

@zugdev

@kingsley-einstein
Copy link
Author

@zugdev

@kingsley-einstein
Copy link
Author

@zugdev
This is taking a lot of time.

@zugdev
Copy link

zugdev commented Jan 23, 2025

on it right now

@zugdev
Copy link

zugdev commented Jan 23, 2025

idk why it glitches in localhost and doesnt load collaterals, do you have any clue?

const currentChain = await provider.request<string>({ method: "eth_chainId" });

if (currentChain !== "0x1") {
await provider.request<null>({ method: "wallet_switchEthereumChain", params: [{ chainId: "0x1" }] });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is bad hardcoding, was hard to spot

Copy link

@zugdev zugdev Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use publicClient.chain.id.toString() instead

const currentChain = await provider.request<string>({ method: "eth_chainId" });

if (currentChain !== "0x1") {
await provider.request<null>({ method: "wallet_switchEthereumChain", params: [{ chainId: "0x1" }] });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use publicClient.chain.id.toString() instead of hardcoding chainId

wallet.updateConnectButtonText("");

await wallet.connectIfAuthorized();
await mint.initCollateralList();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mint and redeem collateralList is the same, but idk if its worth asking for this change at this point

@zugdev
Copy link

zugdev commented Jan 23, 2025

approval works, I didnt manage to mint cause "Stale Stable/USD data" returned from mintDollar

image

@rndquu it probably has to do with the twap range falling behind threshold, can you give some input?

@zugdev
Copy link

zugdev commented Jan 23, 2025

bugs:

  1. inconsistency? this doesnt seem to happen in prod tho, so ignore it.
Screen.Recording.2025-01-23.at.03.21.19.mov
  1. if I switch connected wallet, context doesnt change, for example: when I connect a wallet that doesnt have allowance and switch into another that does have allowance. in that case we should reset form to initial state.
Screen.Recording.2025-01-23.at.03.22.56.mov

@rndquu
Copy link
Member

rndquu commented Jan 23, 2025

approval works, I didnt manage to mint cause "Stale Stable/USD data" returned from mintDollar

@rndquu it probably has to do with the twap range falling behind threshold, can you give some input?

This error refers to the LUSD/USD chainlink price feed. I've just checked it and it's up to date. Are you testing in a real or forked environment? If in a forked one then try to test with another RPC, perhaps that provider is not synced.

@zugdev
Copy link

zugdev commented Jan 24, 2025

Are you testing in a real or forked environment?

I am running yarn test:anvil, yarn test:fund and I've swapped publicClient for local one. I've tried different providers still not working

Copy link

ubiquity-os bot commented Jan 24, 2025

@kingsley-einstein, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot marked this pull request as draft January 24, 2025 07:55
@kingsley-einstein kingsley-einstein marked this pull request as ready for review January 24, 2025 19:45
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't mint UUSD because the Mint UUSD button does not appear after the approval.

Screenshot 2025-01-24 at 23 26 03

@rndquu
Copy link
Member

rndquu commented Jan 24, 2025

Are you testing in a real or forked environment?

I am running yarn test:anvil, yarn test:fund and I've swapped publicClient for local one. I've tried different providers still not working

You could also try running anvil with the --no-storage-caching option.

@rndquu
Copy link
Member

rndquu commented Jan 24, 2025

I've reviewed this PR at least 7 times. There was a point at which it worked more or less fine and we could proceed with that but now minting UUSD doesn't work again.

I think we can unassign @kingsley-einstein, close this PR and ask @zugdev to proceed with #13 (if @0x4007 is ok with this approach).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UI for UbiquityPool
5 participants