-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: initialize #3
base: development
Are you sure you want to change the base?
chore: initialize #3
Conversation
Unused exports (1)
|
@0x4007 I just realized that I was previously unassigned from this task. I already raised a PR. |
minting works now, but you've blocked slippage inputs totally, by gray out I dont mean block, just change the style. it looks good now, but please allow user to input slippage |
@zugdev |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
2 similar comments
@zugdev |
on it right now |
idk why it glitches in localhost and doesnt load collaterals, do you have any clue? |
const currentChain = await provider.request<string>({ method: "eth_chainId" }); | ||
|
||
if (currentChain !== "0x1") { | ||
await provider.request<null>({ method: "wallet_switchEthereumChain", params: [{ chainId: "0x1" }] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is bad hardcoding, was hard to spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use publicClient.chain.id.toString()
instead
const currentChain = await provider.request<string>({ method: "eth_chainId" }); | ||
|
||
if (currentChain !== "0x1") { | ||
await provider.request<null>({ method: "wallet_switchEthereumChain", params: [{ chainId: "0x1" }] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use publicClient.chain.id.toString()
instead of hardcoding chainId
wallet.updateConnectButtonText(""); | ||
|
||
await wallet.connectIfAuthorized(); | ||
await mint.initCollateralList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mint and redeem collateralList is the same, but idk if its worth asking for this change at this point
approval works, I didnt manage to mint cause "Stale Stable/USD data" returned from mintDollar @rndquu it probably has to do with the twap range falling behind threshold, can you give some input? |
bugs:
Screen.Recording.2025-01-23.at.03.21.19.mov
Screen.Recording.2025-01-23.at.03.22.56.mov |
This error refers to the |
I am running yarn test:anvil, yarn test:fund and I've swapped publicClient for local one. I've tried different providers still not working |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also try running anvil with the |
I've reviewed this PR at least 7 times. There was a point at which it worked more or less fine and we could proceed with that but now minting UUSD doesn't work again. I think we can unassign @kingsley-einstein, close this PR and ask @zugdev to proceed with #13 (if @0x4007 is ok with this approach). |
Resolves #1