feat: add kv binding in actions for referral tracker #163
Conversation
|
@zugdev that's the spirit, but removing |
|
I don't know more. |
|
I'll test it out. |
|
@0x4007 can you pls give me actions permission for me to try running this deploy workflow file? |
I missed this. Are you asking to be admin? I'll do that now |
| [env.dev] | ||
| [[env.dev.kv_namespaces]] | ||
| binding = "kv" | ||
| id = "9cd5fdf01971402390dbe9e95cc078d3" |
There was a problem hiding this comment.
This is what we are trying to resolve, it should not be here, the deployment will fail.
There was a problem hiding this comment.
I thought this was what we did at kernel
https://github.com/ubiquity-os/ubiquity-os-kernel/blob/development/wrangler.toml
There was a problem hiding this comment.
We gotta have the production fields else update toml fails cause it doesnt find a field to change
There was a problem hiding this comment.
The kernel does not use any of these, they actually should get removed.
Yes but I think the fields can be empty, like for plugins. Example: https://github.com/ubiquity-os-marketplace/command-start-stop/blob/development/wrangler.toml
|
Managed to make it work by copying kernel, here is QA: https://github.com/ubiquity/work.ubq.fi/actions/runs/12944850895 @gentlementlegen can you take a quick look? |
Resolves #151
@gentlementlegen I know this ain't right as of now, but I'd love some feedback. I've based myself of https://github.com/ubiquity-os/ubiquity-os-kernel/.