Fix/radio buttons508 #1644
Merged
Fix/radio buttons508 #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please find the detailed integration test report here |
vzpgb
approved these changes
Nov 22, 2024
cemile-ctds
approved these changes
Nov 22, 2024
|
Please find the ci env pod logs here |
jarvisraymond-uchicago
merged commit e619330
into
feat/vadc_sprint23
6 of 7 checks passed
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Nov 27, 2024
* VADC-1482: Updated buttons' colors in Eurler diagram according to 508 (#1626) * fix(cardDescriptionParsing): initial commit (#1612) * fix(cardDescriptionParsing): initial commit * fix(cardDescriptionParsing): ranner linter and fixed error * Bugfix/combo box labels (#1611) * bugfix(comboBoxLabels): Began dev of new select box component, need to resolve issues with setting selectedValue * bugfix(comboBoxLabels): made select box a controllable component, moved IsEnterOrSpace into accessibilityUtils folder * bugfix(comboBoxLabels): removed console.log statements * bugfix(comboBoxLabels): ran linter * bugfix(comboBoxLabels): removed commented code * bugfix(comboBoxLabels): ran linter * bugfix(comboBoxLabels): Added Teams Dropdown test * bugfix(comboBoxLabels): updated Teams Dropdown test * bugfix(comboBoxLabels): removed unneeded div element from TeamDropdown * fix(comboBoxLabels): Updated label text * fix(comboBoxLabels): Updated unit test * VADC-1420: Fixed modal button color to ensure accessibility (#1615) * fix(vadc-1420): Fixed modal button color to ensure accessibility * Updated background/border/hover colors for modal window * (VADC-1430): fix(vaLogoAltText) * VADC-1479: Updated Previous/Next buttons' colors for VA GWAS according to 508 (#1618) * fix(vadc-1479): Updated colors for the GWAS next/previous buttons * fix(vadc-1479): Undo automatic discovery style changes * fix(vadc-1479): Updated class in CSS for Previous/Next buttons * Use updated colors only for active button (#1620) * VADC-1516: Updated colors for the buttons in the GWAS modal according to 508 (#1621) * fix(vadc-1516): Updated colors for the buttons in the GWAS modal * fix(vadc-1516): Unify style order * fix(vadc-1516): Refactor CSS * fix(vadc-1516): Added comment * fix(vadc-1516): Updated text color for the dropdown in the Team's modal * fix(vadc-1516): formatting * fix(vadc-1516): formatting * fix(vadc-1516): formatting * fix(vadc-1516): formatting * fix(vadc-1482): Updated button colors in Eurler diagram * fix(vadc-1482): Updated focus color for the Eurler diagram --------- Co-authored-by: Jarvis <[email protected]> * fix: improve error message for Euler diagram ...replacing it with a more generic error message that applies better to all possible error scenarios * Fix/enable legacy vs new data dictionary - part2 (#1629) * fix: revert and bring back old data dictionary button component ...from https://github.com/uc-cdis/data-portal/tree/5dc09282573e93f8e11d44f53d65e3cf677256c6/src/Analysis/AtlasDataDictionary/AtlasDataDictionaryButton ...which in turn is a restore from older code #1478 * fix: using AtlasLegacyDataDictionaryButton for the legacy scenario * fix: remove unused variables * fix: fix AtlasLegacyDataDictionaryButton tests * feat: use feature flag legacyDataDictionary instead of analysis app attribute * fix: remove duplicated AtlasDataDictionaryButton css file * fix: use project specific feature flag name * VADC-1544: Refactor CSS to be more generic (#1635) * fix discovery batch loading (#1632) * fix discovery batch loading * fix return as needed * fix(vadc-1544): Refactor CSS * Branch fix * Missing syntax added * Undo * Undo * fix(vadc-1544): Refactor CSS to LESS * fix(vadc-1544): Formatting * fix(vadc-1544): Formatting --------- Co-authored-by: Mingfei Shao <[email protected]> * add aria label for popup message * remove commit from wrong file * VADC-1472: Change Back to Apps link color according to 508 guidelines (#1640) * fix(vadc-1472): Change link color * fix(vadc-1472): eslint-new configuration * Merge master into release branch 22 (#1643) * fix discovery batch loading (#1632) * fix discovery batch loading * fix return as needed * new changes for B3 WALDER project to make changes for discovery porta… (#1551) * new changes for B3 WALDER project to make changes for discovery portal in PRC * spacing changes for code * changes suggested by mingfei * changes made after mingfei's comments and meeting * eslint on openfillrequestformbutton * added missing variables in discovey config * added null condition and ran eslint * added check for null to pass npm test * added check for null to pass npm test * refactor: simplify button logic by removing redundant check * refactor: remove redundant check from disabled condition * changes for failing test * new variable fillRequestFormCheckField added * changes for if condition * if condition fixes * new property added to allow checkboxes if not logged in * revert change * removed extra space * changed text for tooltip * fixes for props variable * Update src/Discovery/DiscoveryActionBar/components/OpenFillRequestFormButton.tsx Co-authored-by: Mingfei Shao <[email protected]> * changes for tooltip if multiple flags are on * Update src/Discovery/DiscoveryListView.tsx Co-authored-by: Mingfei Shao <[email protected]> --------- Co-authored-by: Mingfei Shao <[email protected]> * Update team project filter (#1633) * update team project filter * update unit test * (VADC-1444): add please login to access text to login page (#1617) * (VADC-1439): add link to access denied page (#1616) * VADC-1448: add logout warning (#1636) * (VADC-1455, VADC-1454, VADC-1424): mis 508 fixes (#1637) * Fix/vadc 1417 (#1638) * update link color * styling format --------- Co-authored-by: Mingfei Shao <[email protected]> Co-authored-by: Urvi Sheth <[email protected]> Co-authored-by: Jian <[email protected]> * VADC-1477, VADC-1487: Fix pagination colors according to 508 guidelines (#1646) * fix(vadc-1477): Fix pagination colors * Formatting * fix(vadc-1477): More pagination styles * Fix/radio buttons508 (#1644) * fix(radioButtons508): initial commit * fix(radioButtons508): resolved eslint issues with proptypes * fix(radioButtons508): removed unintentional changes from auto formatting * fix(radioButtons508): Updated aria label texts * VADC-1486: Fix selected phenotypes/covariates colors according to 508 guidelines (#1648) * fix(vadc-1486): Fix selected phenotypes/covariates colors * fix(vadc-1486): Restore styles for gwas and teams modals --------- Co-authored-by: vzpgb <[email protected]> Co-authored-by: pieterlukasse <[email protected]> Co-authored-by: Mingfei Shao <[email protected]> Co-authored-by: tianj7 <[email protected]> Co-authored-by: Shawn O'Connor <[email protected]> Co-authored-by: Urvi Sheth <[email protected]> Co-authored-by: Jian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/VADC-1457
https://ctds-planx.atlassian.net/browse/VADC-1461
DEV NOTES
Bug Fixes