Fixes instance lock error message, staleTimer, and cacheTimer #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1583 where collaborators of a widget are not meant to edit a widget at the same time. Normally this does not happen, but it was still possible to edit a widget without acquiring the lock for the widget by copy-pasting the link of the creator into the browser.
When they do this now, they are met with an informative alert and it prevents them from being able to close the alert or edit the widget. Additionally, the staleTimer was set to infinity before, which was responsible for requesting the key to the lock. The original creator would hold the lock for 2 minutes but after that it would not do more requests. This PR aims to fix this by adding 2 minutes to the staleTimer in addition adding 3 minutes for the cacheTimer to get rid of the cache every 3 minutes.
There was a minor bug on the include.scss where a dark mode style would be applied as well, I also fixed that with Simon's help.