Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/prometheus/client_golang from 1.18.0 to 1.20.0 #2593

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 15, 2024

Bumps github.com/prometheus/client_golang from 1.18.0 to 1.20.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.20.0

Thanks everyone for contributions!

⚠️ In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

... (truncated)

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.20.0 / 2024-08-14

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

1.19.0 / 2024-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427
Commits
  • 73b811c Cut 1.20.0 release. (#1580)
  • 7ce5089 gocollector: Attach original runtime/metrics metric name to help. (#1578)
  • 062300e Remove go_memstat_lookups_total; added runtime/metrics calculation to memstat...
  • aa3c00d Update common Prometheus files (#1576)
  • 3ad2722 Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /s...
  • 0715727 Update common Prometheus files (#1573)
  • 3634bd9 ci: daggerize test and lint pipelines (#1534)
  • 28b5e6e Merge pull request #1572 from prometheus/repo_sync
  • 8e18075 Update common Prometheus files
  • 46f77a9 Merge pull request #1571 from prometheus/dependabot/github_actions/github-act...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • New Features

    • Updated various dependencies to their latest stable versions, improving compatibility, security, and performance.
  • Bug Fixes

    • Upgraded Prometheus-related libraries to address potential issues and enhance functionality.

These changes ensure a more stable and secure application experience for users.

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.20.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.18.0...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor

coderabbitai bot commented Aug 15, 2024

Walkthrough

The updates to the go.mod file primarily reflect version upgrades for various Go module dependencies, enhancing the project's stability and security. Key changes include significant updates to several Prometheus modules and various indirect dependencies, indicating a commitment to leveraging the latest features and improvements offered by these libraries. The inclusion of a new dependency, github.com/munnerz/goautoneg, further expands the project's capabilities.

Changes

Files/Modules Change Summary
github.com/prometheus/... Upgraded versions of Prometheus modules to enhance features and stability. Notable updates include client_golang to v1.20.0, client_model to v0.6.1, common to v0.55.0, and procfs to v0.15.1.
github.com/klauspost/compress Updated from v1.17.2 to v1.17.9, improving performance and security.
golang.org/x/... Various indirect dependencies updated: crypto to v0.24.0, mod to v0.17.0, net to v0.26.0, sys to v0.22.0, term to v0.21.0, text to v0.16.0, and tools to a newer version with a commit identifier.
github.com/munnerz/goautoneg Newly added dependency for enhanced negotiation capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant Prometheus
    participant IndirectDeps

    App->>Prometheus: Request Monitoring Data
    Prometheus-->>App: Return Data
    App->>IndirectDeps: Fetch Required Features
    IndirectDeps-->>App: Provide Features
    App->>User: Display Results
Loading

Poem

🐇 In the meadow, I hop with glee,
New updates bring joy to me!
Libraries fresh, dependencies bright,
Our code now dances in the light.
With every change, we leap and bound,
A vibrant world in code we've found! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f88a0de and 7a4438b.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (6 hunks)
Additional comments not posted (12)
go.mod (12)

26-26: Verify compatibility with github.com/prometheus/client_golang v1.20.0.

The update to v1.20.0 includes new metrics and removal of go_memstat_lookups_total. Ensure that these changes do not affect the existing functionality.

Verification successful

No usage of removed metric go_memstat_lookups_total found.

The search confirmed that go_memstat_lookups_total is not used in the codebase, so its removal in v1.20.0 should not impact functionality. However, please manually verify other changes introduced in v1.20.0 for compatibility with your code.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of Prometheus metrics in the codebase to ensure compatibility with v1.20.0.

# Test: Search for the removed metric `go_memstat_lookups_total`. Expect: No usage of the removed metric.
rg --type go 'go_memstat_lookups_total'

Length of output: 39


207-207: Verify compatibility with golang.org/x/crypto v0.24.0.

Ensure that the update to v0.24.0 does not introduce any breaking changes or affect the existing cryptographic operations.


208-208: Verify compatibility with golang.org/x/mod v0.17.0.

Ensure that the update to v0.17.0 does not introduce any breaking changes or affect the existing module operations.


175-175: Verify compatibility with github.com/prometheus/client_model v0.6.1.

Ensure that the update to v0.6.1 does not introduce any breaking changes or affect the existing metric models.


176-176: Verify compatibility with github.com/prometheus/common v0.55.0.

Ensure that the update to v0.55.0 does not introduce any breaking changes or affect the existing usage of common utilities.


146-146: Verify compatibility with github.com/klauspost/compress v1.17.9.

Ensure that the update to v1.17.9 does not introduce any breaking changes or affect the existing compression logic.


216-216: Verify compatibility with golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d.

Ensure that the update to v0.21.1-0.20240508182429-e35e4ccd0d2d does not introduce any breaking changes or affect the existing tooling operations.

Verification successful

No direct usage of golang.org/x/tools found in the codebase.

The dependency golang.org/x/tools is listed as indirect in go.mod, indicating it's used by other dependencies. There are no direct imports or usage patterns in the codebase that would be affected by the update to v0.21.1-0.20240508182429-e35e4ccd0d2d. This reduces the likelihood of breaking changes impacting the main project.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `golang.org/x/tools` to ensure compatibility with v0.21.1-0.20240508182429-e35e4ccd0d2d.

# Test: Search for import and usage of `tools`. Expect: No breaking changes in the usage patterns.
rg --type go 'golang.org/x/tools'

Length of output: 33


Script:

#!/bin/bash
# Description: List all dependencies and their versions in go.mod to check for indirect usage of `golang.org/x/tools`.

# Extract all dependencies and their versions from go.mod
cat go.mod

Length of output: 11616


209-209: Verify compatibility with golang.org/x/net v0.26.0.

Ensure that the update to v0.26.0 does not introduce any breaking changes or affect the existing network operations.

Verification successful

Verify compatibility with golang.org/x/net v0.26.0.

The golang.org/x/net package is an indirect dependency, and no direct usage was found in the codebase. It is recommended to review the release notes for v0.26.0 to ensure that there are no breaking changes that could affect transitive dependencies.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `golang.org/x/net` to ensure compatibility with v0.26.0.

# Test: Search for import and usage of `net`. Expect: No breaking changes in the usage patterns.
rg --type go 'golang.org/x/net'

Length of output: 31


Script:

#!/bin/bash
# Description: Check for dependencies in `go.mod` that might indirectly use `golang.org/x/net`.

# Test: List all dependencies in `go.mod` to identify potential indirect users of `golang.org/x/net`.
cat go.mod

Length of output: 11616


212-212: Verify compatibility with golang.org/x/sys v0.22.0.

Ensure that the update to v0.22.0 does not introduce any breaking changes or affect the existing system operations.


214-214: Verify compatibility with golang.org/x/text v0.16.0.

Ensure that the update to v0.16.0 does not introduce any breaking changes or affect the existing text operations.


213-213: Verify compatibility with golang.org/x/term v0.21.0.

Ensure that the update to v0.21.0 does not introduce any breaking changes or affect the existing terminal operations.

Verification successful

No direct usage of golang.org/x/term found in the codebase.

The dependency golang.org/x/term is present in go.sum but is not directly used in the Go code files. The update to version v0.21.0 should not introduce any breaking changes to the existing codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `golang.org/x/term` to ensure compatibility with v0.21.0.

# Test: Search for import and usage of `term`. Expect: No breaking changes in the usage patterns.
rg --type go 'golang.org/x/term'

Length of output: 32


Script:

#!/bin/bash
# Description: Check for references to `golang.org/x/term` in `go.sum` and search for indirect usage in Go files.

# Check for references in `go.sum`.
rg 'golang.org/x/term' go.sum

# Search for potential indirect usage in Go files.
rg --type go 'term' --glob '!go.mod' --glob '!go.sum'

Length of output: 80127


177-177: Verify compatibility with github.com/prometheus/procfs v0.15.1.

Ensure that the update to v0.15.1 does not introduce any breaking changes or affect the existing usage of procfs utilities.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f88a0de and 7a4438b.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (6 hunks)
Additional comments not posted (13)
go.mod (13)

146-146: Minor version update for klauspost/compress.

The update to github.com/klauspost/compress v1.17.9 is a minor version change, likely including bug fixes and performance improvements. This change is approved.


175-175: Minor version update for client_model.

The update to github.com/prometheus/client_model v0.6.1 is a minor version change, likely including bug fixes and improvements. This change is approved.


176-176: Major version update for prometheus/common.

The update to github.com/prometheus/common v0.55.0 includes significant changes. Ensure compatibility with existing code.


177-177: Major version update for prometheus/procfs.

The update to github.com/prometheus/procfs v0.15.1 includes significant changes. Ensure compatibility with existing code.


207-207: Minor version update for x/crypto.

The update to golang.org/x/crypto v0.24.0 is a minor version change, likely including bug fixes and security improvements. This change is approved.


208-208: Minor version update for x/mod.

The update to golang.org/x/mod v0.17.0 is a minor version change, likely including bug fixes and improvements. This change is approved.


209-209: Minor version update for x/net.

The update to golang.org/x/net v0.26.0 is a minor version change, likely including bug fixes and improvements. This change is approved.


212-212: Minor version update for x/sys.

The update to golang.org/x/sys v0.22.0 is a minor version change, likely including bug fixes and improvements. This change is approved.


213-213: Minor version update for x/term.

The update to golang.org/x/term v0.21.0 is a minor version change, likely including bug fixes and improvements. This change is approved.


214-214: Minor version update for x/text.

The update to golang.org/x/text v0.16.0 is a minor version change, likely including bug fixes and improvements. This change is approved.


216-216: Specific commit update for x/tools.

The update to golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d refers to a specific commit. Ensure compatibility with existing code.


26-26: Verify the impact of the client_golang update.

The update to github.com/prometheus/client_golang v1.20.0 includes the removal of the go_memstat_lookups_total metric. Ensure that this metric is not used elsewhere in the codebase.

Verification successful

No impact from the client_golang update.

The go_memstat_lookups_total metric is not used in the codebase, so the update to github.com/prometheus/client_golang v1.20.0 does not affect the current implementation. No further action is required.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the removed `go_memstat_lookups_total` metric in the codebase.

# Test: Search for occurrences of `go_memstat_lookups_total`. Expect: No matches.
rg --type go 'go_memstat_lookups_total'

Length of output: 39


165-165: Verify the necessity of the new goautoneg dependency.

The addition of github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 should be verified to ensure it is necessary and does not introduce any issues.

@gsk967 gsk967 enabled auto-merge August 18, 2024 14:03
@gsk967
Copy link
Collaborator

gsk967 commented Aug 18, 2024

This pr breaking build process

$ make build
RocksDB support is disabled; to build and test with RocksDB support, set ENABLE_ROCKSDB=true
go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=umee -X github.com/cosmos/cosmos-sdk/version.AppName=umeed -X github.com/cosmos/cosmos-sdk/version.Version=6.6.0-9-g7a4438b1 -X github.com/cosmos/cosmos-sdk/version.Commit=7a4438b12700f40bd5e5087286cf3ea020d47304 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/cometbft/cometbft/version.TMCoreSemVer=v0.37.10 -w -s' -trimpath -o /Users/gsk967/Projects/umee-network/umee/build/ ./...
go: downloading github.com/prometheus/client_golang v1.20.0
# github.com/cosmos/cosmos-sdk/telemetry
../../../go/pkg/mod/github.com/cosmos/[email protected]/telemetry/metrics.go:156:37: undefined: expfmt.FmtText
../../../go/pkg/mod/github.com/cosmos/[email protected]/telemetry/metrics.go:163:51: undefined: expfmt.FmtText
make: *** [build] Error 1

@gsk967 gsk967 closed this Aug 18, 2024
auto-merge was automatically disabled August 18, 2024 14:05

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 18, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.20.0 branch August 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant