Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-js): less async #15385

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(unlock-js): less async #15385

merged 1 commit into from
Jan 21, 2025

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Jan 21, 2025

Description

Moving away from Promise.all as it seems to create issues with rate limits and errors are not easily cattchable.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jan 21, 2025
@julien51 julien51 requested a review from 0xTxbi January 21, 2025 23:00
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Jan 21, 2025 11:00pm
unlock-storybook ⬜️ Ignored (Inspect) Jan 21, 2025 11:00pm

@julien51 julien51 changed the title less async feat(unlock-js): less async Jan 21, 2025
@julien51 julien51 merged commit 55a12d6 into master Jan 21, 2025
16 checks passed
@julien51 julien51 deleted the less-async branch January 21, 2025 23:45
julien51 added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants