Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance filter option handling for HTML image embedding support #145

Closed
wants to merge 1 commit into from

Conversation

kracas
Copy link

@kracas kracas commented Nov 6, 2024

The default behaviour of embedding images as base64 strings in output HTML files was changed for newer libreoffice versions. This was then made optional and you could specify this in the soffice commands like so:

soffice –headless --convert-to html:HTML:EmbedImages test_file.docx

However using --filter-options EmbedImages=true does not work, because it sets FilterData property, whereas for EmbedImages option FilterOptions property needs to be set to EmbedImages.

This PR makes it possible to use EmbedImages filter option this way:
unoconvert --convert-to html --filter HTML --filter-options EmbedImages=true test_file.docx test_file.html
or just
unoconvert --convert-to html --filter HTML --filter-options EmbedImages= test_file.docx test_file.html

Fixes #24 #75 #110

@regebro
Copy link
Member

regebro commented Dec 1, 2024

OK, I understand what is happening here now, I implemented this in a more generic fashion. Version 3.1 is out now.

@regebro regebro closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can i use custom filter in convertation?
2 participants