Enhance filter option handling for HTML image embedding support #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of embedding images as base64 strings in output HTML files was changed for newer libreoffice versions. This was then made optional and you could specify this in the soffice commands like so:
soffice –headless --convert-to html:HTML:EmbedImages test_file.docx
However using
--filter-options EmbedImages=true
does not work, because it setsFilterData
property, whereas forEmbedImages
optionFilterOptions
property needs to be set toEmbedImages
.This PR makes it possible to use
EmbedImages
filter option this way:unoconvert --convert-to html --filter HTML --filter-options EmbedImages=true test_file.docx test_file.html
or just
unoconvert --convert-to html --filter HTML --filter-options EmbedImages= test_file.docx test_file.html
Fixes #24 #75 #110