-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjust combobox template for editable feature #1516
base: master
Are you sure you want to change the base?
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1516.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1516.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1516.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1516.eastus2.azurestaticapps.net |
To have it aligned in all platforms i had to use these padding values here.
I also tried wrapping both the Recording.2025-01-14.155308.mp4This video is it running on Windows, but it's very similar on the other platforms. |
<Style x:Key="MaterialComboBoxStyle" | ||
TargetType="ComboBox"> | ||
<Setter Property="Foreground" Value="{ThemeResource ComboBoxForeground}" /> | ||
<Setter Property="Background" Value="{ThemeResource ComboBoxBackground}" /> | ||
<Setter Property="BorderBrush" Value="{ThemeResource ComboBoxBorderBrush}" /> | ||
<Setter Property="BorderThickness" Value="{ThemeResource ComboBoxBorderThickness}" /> | ||
<Setter Property="Padding" Value="{ThemeResource ComboBoxPadding}" /> | ||
|
||
<Setter Property="TextBoxStyle" Value="{StaticResource MaterialComboBoxTextBoxStyle}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just opening a thread here for the textbox on focus padding/alignment problem: #1516 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance, it seems that the presence of the caret is pushing the element.
Have you tried to have a fixed height on the textbox or its scrollviewer (in textbox template) and set them to align bottom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the Height on the TextBox
doesn't make any difference. I'm trying now to set the ScrollViewer (in the textbox template) height to 35 and its VerticalAlignment to bottom (also set scrollviewer bckgd to green). I had to remove the Padding and it looks like:
Windows - looks good
Recording.2025-01-14.172151.mp4
Skia
Closes #1518