-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dockerfile #160
base: main
Are you sure you want to change the base?
added dockerfile #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with adding a Dockerfile specifically for charites, thanks for your Pull Request!
I think there should be a blank line at the end of the file.
Ref: https://stackoverflow.com/a/729795
And I thought the Dockerfile could be simpler as well.
Ref: https://github.com/yuiseki/charites-ai/blob/main/Dockerfile
WORKDIR /usr/src/app | ||
COPY package*.json . | ||
RUN npm install | ||
COPY . . | ||
RUN npm run build | ||
RUN npm install -g . | ||
RUN chmod +x entrypoint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a simple Dockerfile like the following would work fine.
WORKDIR /usr/src/app | |
COPY package*.json . | |
RUN npm install | |
COPY . . | |
RUN npm run build | |
RUN npm install -g . | |
RUN chmod +x entrypoint.sh | |
COPY . /app | |
WORKDIR /app | |
RUN npm ci | |
RUN npm run build | |
RUN npm install -g . | |
RUN chmod +x entrypoint.sh |
RUN npm install -g . | ||
RUN chmod +x entrypoint.sh | ||
|
||
ENTRYPOINT [ "./entrypoint.sh" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a blank line at the end of the file
ENTRYPOINT [ "./entrypoint.sh" ] | |
ENTRYPOINT [ "./entrypoint.sh" ] | |
@@ -0,0 +1,3 @@ | |||
#!/bin/bash -e | |||
|
|||
exec charites "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I suggest a blank line at the end of the file
exec charites "$@" | |
exec charites "$@" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all!
Description
unvt/nanban can't build in arm64 arch, so I make Dockerfile for charites only.
Type of Pull Request
Verify the followings
main
branchnpm run build
npm run lint
charites help
globallyRefer to CONTRIBUTING.MD for more details.