Quaterniond::w returns const double & instead of double to work with … #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Eigen CoeffReturnType
|
@uoip please merge this! |
|
@uoip this fixes the problem, please merge |
|
This fixed my problem, please merge! 👍 |
|
This fixed the issue for me on OSX. Please do merge 👍 |
|
Same here. This fixed the compilation for me in MacOS Mojave. |
|
Please merge this. This fixed the compilation problem on MacOS Catalina. |
|
This fixed my problem on macOS Big Sur, please merge! 👍 |
|
This does indeed fix the issue |
|
PLEASE fix this issue. |
|
Works like a charm! Please integrate this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Eigen CoeffReturnType
Eigen has this new CoeffReturnType typedef which causes build to fail.
https://eigen.tuxfamily.org/dox/DenseCoeffsBase_8h_source.html