Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the repo name calculation logic in the Updoc CI workflow #196

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Mar 14, 2024

Description of your changes

As we moved the official providers upbound/provider-{aws, azure, azuread, gcp} to their homes crossplane-contrib/provider-upjet-{aws, azure, azuread, gcp}, we will need to fix/change the provider repo name calculation in the reusable Updoc workflow so that we still compute the old repo names for these providers. This is required because although we have moved these providers to new repositories, the published package names are kept intact for backwards compatibility reasons.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested the changes proposed in this PR here: https://github.com/ulucinar/uptest/actions/runs/8283714517/job/22667549446

Please note that even if we pass provider-aws or provider-upjet-aws, the calculated package names are as expected, e.g., provider-aws-ec2.

@ulucinar ulucinar requested a review from sergenyalcin as a code owner March 14, 2024 15:41
@ulucinar ulucinar marked this pull request as draft March 14, 2024 15:41
@ulucinar ulucinar marked this pull request as ready for review March 14, 2024 16:00
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit af5d22a into upbound:main Mar 14, 2024
6 checks passed
@ulucinar ulucinar deleted the fix-updoc branch March 14, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants