-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ESLint
to v9
and prettier
to v3
#80
Open
risantos
wants to merge
7
commits into
master
Choose a base branch
from
feature/eslint-9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risantos
force-pushed
the
feature/eslint-9
branch
5 times, most recently
from
October 16, 2024 14:29
834a6b7
to
ed94b37
Compare
risantos
force-pushed
the
feature/eslint-9
branch
from
October 16, 2024 15:52
ed94b37
to
4d22cbf
Compare
risantos
force-pushed
the
feature/eslint-9
branch
4 times, most recently
from
November 5, 2024 17:29
24aa945
to
16a5546
Compare
risantos
force-pushed
the
feature/eslint-9
branch
4 times, most recently
from
November 18, 2024 20:17
077b2bf
to
ed957c2
Compare
- Raises the minimum required Node.js version to `v20` Additionally, bumps: - `@babel/core` - `@babel/eslint-parser` - `eslint-config-prettier` - `eslint-plugin-jsdoc` - `esling-plugin-mocha` - `eslint-plugin-prettier` - `eslint-plugin-promise` - `eslint-plugin-sort-destructure-keys` - `eslint-plugin-sort-imports-requires` - `eslint-plugin-sql-template` - `globals` - `release-it`
These were deprecated in ESLint v8.53.0 - `no-tabs` - https://eslint.org/docs/latest/rules/no-tabs - `padding-line-between-statements` - https://eslint.org/docs/latest/rules/padding-line-between-statements - `spaced-comment` - https://eslint.org/docs/latest/rules/spaced-comment
- Deprecated in ESLint `v8.50.0`, replaced with `no-object-constructor` - https://eslint.org/docs/latest/rules/no-new-object#rule-details
These were deprecated in ESLint 7.0.0 - `no-mixed-requires` - https://eslint.org/docs/latest/rules/no-mixed-requires - `no-new-require` - https://eslint.org/docs/latest/rules/no-new-require - `no-path-concat` - https://eslint.org/docs/latest/rules/no-path-concat - `no-process-env` - https://eslint.org/docs/latest/rules/no-process-env - `no-process-exit` - https://eslint.org/docs/latest/rules/no-process-exit - `no-restricted-modules` - https://eslint.org/docs/latest/rules/no-restricted-modules - Replaced by `no-restricted-imports` and `no-restricted-exports` - `no-sync` - https://eslint.org/docs/latest/rules/no-sync
risantos
force-pushed
the
feature/eslint-9
branch
from
January 3, 2025 01:47
ed957c2
to
d17fadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
ESLint
tov9
.eslint.config.js
is the new default configuration format. The previous format, eslintrc, is now deprecated. See more on ESLint blog.Upgrades
prettier
tov3
, to supportESLint@v9
.Raises the minimum required Node.js version to
v20
.Adds
@stylistic/eslint-plugin-js
to fix deprecated rules, deprecated in ESLint v8.53.0no-tabs
- https://eslint.org/docs/latest/rules/no-tabspadding-line-between-statements
- https://eslint.org/docs/latest/rules/padding-line- between-statementsspaced-comment
- https://eslint.org/docs/latest/rules/spaced-commentReplaces the rule
no-new-object
withno-object-constructor
, which was deprecated in ESLintv8.50.0
- https://eslint.org/docs/latest/rules/no-new-object#rule-detailsAdds
eslint-plugin-n
to fix deprecated rules, deprecated in ESLint 7.0.0:no-mixed-requires
- https://eslint.org/docs/latest/rules/no-mixed-requiresno-new-require
- https://eslint.org/docs/latest/rules/no-new-requireno-path-concat
- https://eslint.org/docs/latest/rules/no-path-concatno-process-env
- https://eslint.org/docs/latest/rules/no-process-envno-process-exit
- https://eslint.org/docs/latest/rules/no-process-exitno-restricted-modules
- https://eslint.org/docs/latest/rules/no-restricted-modulesno-restricted-imports
andno-restricted-exports
no-sync
- https://eslint.org/docs/latest/rules/no-syncExcludes
bin/*
andscript/*
from theno-process-exit
rule.Disables the
jsdoc/tag-lines
rule, introduced recently, as this shouldn't be enforced by default.Additionally, bumps:
@babel/core
@babel/eslint-parser
eslint-config-prettier
eslint-plugin-jsdoc
esling-plugin-mocha
eslint-plugin-prettier
eslint-plugin-promise
eslint-plugin-sort-destructure-keys
eslint-plugin-sort-imports-requires
eslint-plugin-sql-template
globals