Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependencies for standalone app #10

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add missing dependencies for standalone app #10

merged 1 commit into from
Dec 16, 2024

Conversation

ProchaLu
Copy link
Member

Closes #7

This PR adds missing dependencies for the production build.

karlhorky
karlhorky approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@karlhorky karlhorky left a comment •
edited by ProchaLu
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! just remember to also make the change to next

@ProchaLu ProchaLu merged commit bdd3f80 into main Dec 16, 2024
1 check passed
@karlhorky karlhorky deleted the add-missing-dependencies branch December 16, 2024 09:05
@ProchaLu
Copy link
Member Author

Made the change to the next branch in this commit
f9a93f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlhorky karlhorky karlhorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent errors between Expo Go and standalone app with unused dependencies
2 participants
@ProchaLu @karlhorky