Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build workaround for Netlify Next.js v5 #170

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

ProchaLu
Copy link
Member

@ProchaLu ProchaLu commented Mar 13, 2024

Closes #164

With Netlify's update to the Next.js Runtime v5, improvements have been introduced, including support for ESM and Next/Image. As a result, the workaround we previously created, using the sed command to modify type:module to type:commonJs during the build process, is no longer necessary.

Test

  • Removed the build command workaround and re-deployed on Netlify, the latest @netlify/[email protected] was added, and the images are visible using Next/Image.
1:58:59 PM: ❯ Installing plugins
1:58:59 PM:    - @netlify/[email protected]
Screenshot 2024-03-13 at 14 45 53

@ProchaLu ProchaLu changed the base branch from master to main March 13, 2024 16:00
@karlhorky karlhorky merged commit d16c684 into main Mar 14, 2024
3 checks passed
@karlhorky karlhorky deleted the remove-build-workaround branch March 14, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert temporary workaround for Netlify, ESM, next/image
2 participants