Avoid ESLint path resolution errors on Windows

[karlhorky]

Avoid ESLint path resolution errors on Windows, such as this test run failure:

> @upleveled/[email protected] test D:\a\preflight\preflight
> tsdx test "--ci" "--maxWorkers=2"

FAIL __tests__/e2e.test.ts (69.746 s)
  × Passes in the react-passing test project (9630 ms)
  × Passes in the next-js-passing test project (86[14](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:15) ms)

  ● Passes in the react-passing test project

    expect(received).toMatchSnapshot()

    Snapshot name: `Passes in the react-passing test project 1`

    - Snapshot  - 1
    + Received  + 0

    @@ -1,8 +1,7 @@
      "🚀 UpLeveled Preflight
      [COMPLETED] All changes committed to Git
    - [COMPLETED] ESLint
      [COMPLETED] ESLint config is latest version
      [COMPLETED] GitHub repo has deployed project link under About
      [COMPLETED] No dependencies without types
      [COMPLETED] No dependency problems
      [COMPLETED] No extraneous files committed to Git

      104 |   );
      105 |
    > 106 |   expect(sortStdoutAndStripVersionNumber(stdout)).toMatchSnapshot();
          |                                                   ^
      107 |   expect(stderr.replace(/^\(node:\d+\) /, '')).toMatchSnapshot();
      108 | }, 30000);
      109 |

      at Object.<anonymous> (__tests__/e2e.test.ts:106:51)

  ● Passes in the react-passing test project
      [COMPLETED] ESLint config is latest version
      [COMPLETED] GitHub repo has deployed project link under About
      [COMPLETED] Next.js project has sharp installed
      [COMPLETED] No dependencies without types
      [COMPLETED] No dependency problems

      1[16](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:17) |   );
      1[17](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:18) |
    > 1[18](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:19) |   expect(sortStdoutAndStripVersionNumber(stdout)).toMatchSnapshot();
          |                                                   ^
      1[19](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:20) |   expect(stderr.replace(/^\(node:\d+\) /, '')).toMatchSnapshot();
      1[20](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:21) | }, 45000);
      1[21](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:22) |

      at Object.<anonymous> (__tests__/e2e.test.ts:118:51)

  ● Passes in the next-js-passing test project

    expect(received).toMatchSnapshot()

    Snapshot name: `Passes in the next-js-passing test project 2`

    - Snapshot  -  1
    + Received  + 17

    - ""
    + "[FAILED] Command failed with exit code 2: pnpm eslint . --max-warnings 0 --format json
    +
    + Oops! Something went wrong! :(
    +
    + ESLint: 8.53.0
    +
    + Error: Cannot find package 'D:\a\preflight\preflight\__tests__\fixtures\__temp\next-js-passing\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@ty_xvhbeu5qc6hlxssq5gmtnagbti\node_modules\eslint-plugin-jsx-expressions\package.json' imported from D:\a\preflight\preflight\__tests__\fixtures\__temp\next-js-passing\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@ty_xvhbeu5qc6hlxssq5gmtnagbti\node_modules\eslint-config-upleveled\index.js
    + Did you mean to import [email protected]_@[email protected][email protected][email protected]/node_modules/eslint-plugin-jsx-expressions/dist/index.js?
    +     at legacyMainResolve (node:internal/modules/esm/resolve:189:26)
    +     at packageResolve (node:internal/modules/esm/resolve:776:14)
    +     at moduleResolve (node:internal/modules/esm/resolve:838:20)
    +     at defaultResolve (node:internal/modules/esm/resolve:1043:11)
    +     at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    +     at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    +     at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:[22](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:23)8:38)
    +     at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    +     at link (node:internal/modules/esm/module_job:84:[36](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:37))"

      117 |
      118 |   expect(sortStdoutAndStripVersionNumber(stdout)).toMatchSnapshot();
    > 119 |   expect(stderr.replace(/^\(node:\d+\) /, '')).toMatchSnapshot();
          |                                                ^
      120 | }, 45000);
      121 |

      at Object.<anonymous> (__tests__/e2e.test.ts:119:48)

 › 4 snapshots failed.
Snapshot Summary
 › 4 snapshots failed from 1 test suite. Inspect your code changes or re-run jest with `-u` to update them.

Test Suites: 1 failed, 1 total
Tests:       2 failed, 2 total
Snapshots:   4 failed, 4 total
Time:        70.[43](https://github.com/upleveled/preflight/actions/runs/6842461034/job/18603950750#step:15:44)6 s
Ran all test suites.
 ELIFECYCLE  Test failed. See above for more details.
Error: Process completed with exit code 1.

Funny enough, the file that it cannot resolve above (D:\a\preflight\preflight\__tests__\fixtures\__temp\next-js-passing\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@ty_xvhbeu5qc6hlxssq5gmtnagbti\node_modules\eslint-plugin-jsx-expressions\package.json) actually does exist on disk:

const { stdout: stdout1 } = await execaCommand('dir', {
  cwd: `D:\\a\\preflight\\preflight\\__tests__\\fixtures\\__temp\\react-passing\\node_modules\\.pnpm\\[email protected]_@[email protected]_@[email protected]_@ty_xvhbeu5qc6hlxssq5gmtnagbti\\node_modules\\eslint-plugin-jsx-expressions\\`,
});
console.log(stdout1);
// README.md  dist  docs  node_modules  package.json

So seems like a bug in ESLint's package resolution, opened an issue

[github-actions]

size-limit report 📦

Path	Size
dist/preflight.esm.js	7.4 KB (0%)

[karlhorky]

So the reason that the node-linker=hoisted in .npmrc in b2c193b works is that ESLint and Node.js have a problem with long paths (paths over the 260 character MAX_PATH limit on Windows):

• Bug: Long node_modules plugin paths cannot be found on Windows eslint/eslint#17763
• Long node_modules paths cannot be found on Windows when LongPathsEnabled enabled nodejs/node#50753

So if we reduce the path length, then that would be another solution

[karlhorky]

Using tmpdir() from node:os is another option, and doesn't require us to change the way pnpm installs on Windows.

[karlhorky]

we have to increase the timeout because it takes longer for pnpm to install on Windows in tmpdir() apparently