Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency upgrades - non-major #597

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 14, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
algoliasearch 5.13.0 -> 5.14.0 age adoption passing confidence
pnpm (source) 9.12.3+sha512.cce0f9de9c5a7c95bef944169cc5dfe8741abfb145078c0d508b868056848a87c81e626246cb60967cbd7fd29a6c062ef73ff840d96b3c86c40ac92cf4a813ee -> 9.13.2 age adoption passing confidence
vitest (source) 2.1.4 -> 2.1.5 age adoption passing confidence

Release Notes

algolia/algoliasearch-client-javascript (algoliasearch)

v5.14.0

Compare Source

pnpm/pnpm (pnpm)

v9.13.2

Compare Source

v9.13.1

Compare Source

v9.13.0

Compare Source

vitest-dev/vitest (vitest)

v2.1.5

Compare Source

   🚀 Features
   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

Configuration

📅 Schedule: Branch creation - "after 4pm on thursday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot enabled auto-merge (squash) November 14, 2024 17:06
Copy link

codesandbox-ci bot commented Nov 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

socket-security bot commented Nov 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: network +13 9.87 MB shortcuts
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +39 10.6 MB antfu, oreanno, patak, ...1 more

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@renovate renovate bot force-pushed the renovate/dependency-upgrades-non-major branch from 196bfa7 to 64b331b Compare November 14, 2024 19:28
@karlhorky
Copy link
Member

karlhorky commented Nov 14, 2024

> vitest run


 RUN  v2.1.5 /home/runner/work/preflight/preflight

 ❯ __tests__/e2e.test.ts (2 tests | 2 skipped) 927ms

⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  __tests__/e2e.test.ts [ __tests__/e2e.test.ts ]
ExecaError: Command failed with exit code 254: pnpm add --global '/home/runner/work/preflight/preflight/Tarball Contents\nbin/preflight.sh\nLICENSE\npackage.json\nREADME.md\nsrc/checks/allChangesCommittedToGit.ts\nsrc/checks/eslint.ts\nsrc/checks/eslintConfigIsValid.ts\nsrc/checks/linkOnGithubAbout.ts\nsrc/checks/nodeModulesIgnoredFromGit.ts\nsrc/checks/noDependencyProblems/noDependenciesWithoutTypes.ts\nsrc/checks/noDependencyProblems/noUnusedDependencies.ts\nsrc/checks/noExtraneousFilesCommittedToGit.ts\nsrc/checks/noSecretsCommittedToGit.ts\nsrc/checks/preflightIsLatestVersion.ts\nsrc/checks/prettier.ts\nsrc/checks/projectFolderNameMatchesCorrectFormat.ts\nsrc/checks/stylelint.ts\nsrc/checks/stylelintConfigIsValid.ts\nsrc/checks/useSinglePackageManager.ts\nsrc/index.ts\nsrc/util/commandExample.ts\nsrc/util/crossPlatform.ts\nsrc/util/drone.ts\nsrc/util/packageJson.ts\nsrc/util/preflightBinPath.ts\nsrc/util/randomUserAgent.ts\n\nTarball Details\nupleveled-preflight-8.0.4.tgz'

\u2009ENOENT\u2009 ENOENT: no such file or directory, open '/home/runner/work/preflight/preflight/Tarball Contents
bin/preflight.sh
LICENSE
package.json
README.md
src/checks/allChangesCommittedToGit.ts
src/checks/eslint.ts
src/checks/eslintConfigIsValid.ts
src/checks/linkOnGithubAbout.ts
src/checks/nodeModulesIgnoredFromGit.ts
src/checks/noDependencyProblems/noDependenciesWithoutTypes.ts
src/checks/noDependencyProblems/noUnusedDependencies.ts
src/checks/noExtraneousFilesCommittedToGit.ts
src/checks/noSecretsCommittedToGit.ts
src/checks/preflightIsLatestVersion.ts
src/checks/prettier.ts
src/checks/projectFolderNameMatchesCorrectFormat.ts
src/checks/stylelint.ts
src/checks/stylelintConfigIsValid.ts
src/checks/useSinglePackageManager.ts
src/index.ts
src/util/commandExample.ts
src/util/crossPlatform.ts
src/util/drone.ts
src/util/packageJson.ts
src/util/preflightBinPath.ts
src/util/randomUserAgent.ts

Tarball Details
upleveled-preflight-8.0.4.tgz'

This error happened while installing a direct dependency of /home/runner/setup-pnpm/node_modules/.bin/global/5


 ❯ getFinalError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/final-error.js:6:9
 ❯ makeError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/result.js:108:16
 ❯ getAsyncResult node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:167:4
 ❯ handlePromise node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:150:17
 ❯ __tests__/e2e.test.ts:11:5
      9|     // Pack and install Preflight globally
     10|     const { stdout: pnpmPackTarballPath } = await execa`pnpm pack`;
     11|     await execa`pnpm add --global ${process.cwd()}/${pnpmPackTarballPa…
       |     ^
     12| 
     [13](https://github.com/upleveled/preflight/actions/runs/11844166449/job/33006754543?pr=597#step:12:14)|     await pMap(

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed (1)

Failure from Tarball Contents output caused by:

@karlhorky
Copy link
Member

karlhorky commented Nov 14, 2024

GitHub Workspace command:

Fix the test in __tests__/e2e.test.ts for the pnpm pack output

Before (output of pnpm pack with previous version of pnpm):

upleveled-preflight-7.1.1.tgz

After (output of pnpm pack with new version of pnpm added in this PR):

...

Tarball Details
upleveled-preflight-7.1.1.tgz

Probably best to split the lines and then match the line by the upleveled-preflight-... pattern

@renovate renovate bot force-pushed the renovate/dependency-upgrades-non-major branch from 64b331b to 35c1b5b Compare November 15, 2024 04:15
* Split the lines and match the line by the `preflight-...` pattern
* Remove the intermediary `pnpmPackOutput` variable and wrap the await expression in parentheses
* Use a more forgiving regex pattern for matching `preflight-...`
* Add error handling for missing tarball path in `pnpm pack` output
@renovate renovate bot merged commit cb822b1 into main Nov 15, 2024
6 checks passed
@renovate renovate bot deleted the renovate/dependency-upgrades-non-major branch November 15, 2024 09:03
@karlhorky
Copy link
Member

Now that pnpm pack --json is coming, we'll switch to that instead of the workaround above:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant