Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updates Go to 1.23 #277

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Chore: Updates Go to 1.23 #277

merged 4 commits into from
Jan 16, 2025

Conversation

CGoodwin90
Copy link
Contributor

Updates Go to 1.23

go.mod Show resolved Hide resolved
@shreddedbacon
Copy link
Member

shreddedbacon commented Jan 15, 2025

Based on this #277 (comment) I've marked this as blocked for the moment while we figure out if we have to change the minimum supported version.

@shreddedbacon
Copy link
Member

@CGoodwin90 we'll move ahead with setting the minimum harbor version to 2.7.0 chart 1.11.0.

Looks like you've already updated the github action to do that which is good. I'll need to remove the older 1.9.0 tests so they aren't checked now.

@CGoodwin90 CGoodwin90 marked this pull request as ready for review January 15, 2025 23:08
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We just need to ensure that whichever version of the lagoon-build-deploy and lagoon-remote charts feature the version that contains this change reports that the minimum harbor version supported is now v2.7.0 or chart version 1.11.0

@shreddedbacon shreddedbacon merged commit f2c147f into main Jan 16, 2025
10 checks passed
@shreddedbacon shreddedbacon deleted the update-go-123 branch January 16, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants