Refactor filtering again: this time make subclasses of Filter with filter_records(...) methods
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These subclasses can separately apply the filter to data
Don't build the filtering algorithm into the `MicrocalDataSet` but into the `FilterATS` or `Filter5Lag` class instead. Fixes #314.
ggggggggg
reviewed
Dec 9, 2024
| return self.convolution_lags == 1 and self.dt_values is not None | ||
| return False | ||
|
|
||
| @property |
There was a problem hiding this comment.
Are we supposed to never make an object of type Filter? In that case consider naming is BaseFilter and def __init__(self, ...): raise Error? Move the error as early as possible.
There was a problem hiding this comment.
You're right. And...it turns out there's a package and a special decorator to enforce this. I'll use that.
There was a problem hiding this comment.
And it did exist already in Python 3.9, so we are safe to use it.
|
Revised following @ggggggggg's suggestions in this review. |
ggggggggg
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes filtering algorithms from the
MicrocalDataSetinto thefilter_records(...)methods of the various subclasses ofFilter. In so doing, manyifbranches are removed (or at least, they are hidden from the user).Fixes #314.