Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cleanup feature for MUs and SCC repositories #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atighineanu
Copy link

@atighineanu atighineanu commented Sep 17, 2021

Related card: https://github.com/SUSE/spacewalk/issues/15435

Added cleanup feature for MUs and SCC repositories

without this patch users will have to delete manually all the ibs:/ (MUs) and SCC (normal products, updates and installers repos)
folders manually.
This feature will be used separately depending on the kind of run.
For SCC:

./minima sync --cleanup --auto-approve

For MUs:

./minima updates --cleanup --auto-approve

If you want to cherry-pick which of the undeclared in yaml repositories you want to keep, run:

./minima updates --cleanup 

---> you will be prompted to chose with y/n for each undeclared in minima config yaml repository what to do with it.

Copy link

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, and this will be utterly useful, thanks

but i cannot judge the details of the code, and I think the correct person to approve is Silvio

just add doc before, please

@ktsamis
Copy link

ktsamis commented Sep 17, 2021

it looks good to me, and this will be utterly useful, thanks

but i cannot judge the details of the code, and I think the correct person to approve is Silvio

just add doc before, please

Same for me, I don't know Golang that much but as a feature it's great :)

@avshiliaev
Copy link

@moio @rjmateus hey guys, I guess you could also take a quick look here. I've nitpicked a couple of small things to be changed in the PR, but I'm not sure how important would it be to take care of the code style for such a project? I believe there's some optimization potential there.

@avshiliaev
Copy link

@moio Onee thing puzzles me here. I cannot found where this method should come from 😃

@atighineanu
Copy link
Author

@moio Onee thing puzzles me here. I cannot found where this method should come from 😃

It was supposed to be a method in get/gcp.go, addressing the same kind of functionality against gc storage (was a WIP). Right now it is in fact obsolete.

@srbarrios srbarrios requested review from avshiliaev and removed request for moio July 24, 2023 12:14
@ktsamis ktsamis removed their request for review January 15, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants