Fix the mirror PV handling #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PV has no claimRef, the generated JSON fragment will miss a value and won't be valid. Output the whole PV as JSON and parse it using the Kubernetes API type. The volume mount for the mirror is also missing in the container.
cbosdo
force-pushed
the
k8s-mirror-fix
branch
from
712886b to
a49d062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
If the PV has no claimRef, the generated JSON fragment will miss a value and won't be valid. Output the whole PV as JSON and parse it using the Kubernetes API type.
The volume mount for the mirror is also missing in the container.
Codespace
Check if you already have a running container clicking on
Test coverage
No tests: not sure we could add meaningful tests here
DONE
Links
Issue(s): uyuni-project/uyuni#9542
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!