Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter packages by build time in CLM #7582

Conversation

wweellddeerr
Copy link
Contributor

@wweellddeerr wweellddeerr commented Sep 25, 2023

What does this PR change?

It adds a new option to CLM, allowing users to filter packages by build date.

GUI diff

Before:

After:

image

  • DONE

Documentation

Test coverage

  • Unit tests were added

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/13350

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Suggested tests to cover this Pull Request
  • srv_add_rocky8_repositories
  • srv_rename_hostname
  • allcli_sanity
  • allcli_update_activationkeys
  • srv_monitoring
  • proxy_branch_network
  • proxy_cobbler_pxeboot

Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wweellddeerr,
We've had some discussions about the requirements for this, and here's what we've come up with:

Using multiple sources for the date will be ultimately confusing for the user so for this filter we should use only the build date and not fall back to the created date or anything else.

To convey this properly, we should change all the UI and code occurrences of "package issue date" or "issue date" to just "Package (Build Date)" or "build date", etc.

@wweellddeerr wweellddeerr force-pushed the clm-filter-packages-by-issue-date branch from 9898667 to 19ec168 Compare October 30, 2023 13:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7582/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7582/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@wweellddeerr wweellddeerr changed the title Add option to filter packages by issue date in CLM Add option to filter packages by build time in CLM Oct 30, 2023
@wweellddeerr wweellddeerr marked this pull request as ready for review October 30, 2023 16:55
@wweellddeerr wweellddeerr requested a review from a team as a code owner October 30, 2023 16:55
@wweellddeerr wweellddeerr requested review from Etheryte and removed request for a team October 30, 2023 16:55
@wweellddeerr
Copy link
Contributor Author

Hi @wweellddeerr, We've had some discussions about the requirements for this, and here's what we've come up with:

Using multiple sources for the date will be ultimately confusing for the user so for this filter we should use only the build date and not fall back to the created date or anything else.

To convey this properly, we should change all the UI and code occurrences of "package issue date" or "issue date" to just "Package (Build Date)" or "build date", etc.

Changed, accordingly.

Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @wweellddeerr LGTM 👍

One minor thing:
This came from a Jira request, so you need to add the Jira tracker ID to the changelog entries like "(jsc#SUMA-282)" just like we do with the bsc#s

@wweellddeerr wweellddeerr force-pushed the clm-filter-packages-by-issue-date branch from 19ec168 to e425110 Compare November 2, 2023 16:47
@wweellddeerr wweellddeerr force-pushed the clm-filter-packages-by-issue-date branch 2 times, most recently from a2b0552 to 4b476c8 Compare November 21, 2023 13:56
@wweellddeerr wweellddeerr force-pushed the clm-filter-packages-by-issue-date branch from 4b476c8 to eea04a3 Compare November 21, 2023 18:03
@wweellddeerr wweellddeerr merged commit 616f99f into uyuni-project:master Nov 21, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants