-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to filter packages by build time in CLM #7582
Add option to filter packages by build time in CLM #7582
Conversation
Suggested tests to cover this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wweellddeerr,
We've had some discussions about the requirements for this, and here's what we've come up with:
Using multiple sources for the date will be ultimately confusing for the user so for this filter we should use only the build date
and not fall back to the created
date or anything else.
To convey this properly, we should change all the UI and code occurrences of "package issue date" or "issue date" to just "Package (Build Date)" or "build date", etc.
9898667
to
19ec168
Compare
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Changed, accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @wweellddeerr LGTM 👍
One minor thing:
This came from a Jira request, so you need to add the Jira tracker ID to the changelog entries like "(jsc#SUMA-282)" just like we do with the bsc#s
19ec168
to
e425110
Compare
a2b0552
to
4b476c8
Compare
4b476c8
to
eea04a3
Compare
What does this PR change?
It adds a new option to CLM, allowing users to filter packages by build date.
GUI diff
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
Unit tests were added
DONE
Links
Fixes https://github.com/SUSE/spacewalk/issues/13350
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: