-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider server id when removing invalid erratas from rhnSet #7660
Merged
wweellddeerr
merged 1 commit into
uyuni-project:master
from
wweellddeerr:improve-invalid-errata-delete
Oct 10, 2023
Merged
Consider server id when removing invalid erratas from rhnSet #7660
wweellddeerr
merged 1 commit into
uyuni-project:master
from
wweellddeerr:improve-invalid-errata-delete
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested tests to cover this Pull Request
|
mcalmer
reviewed
Oct 9, 2023
java/spacewalk-java.changes.welder.improve-invalid-errata-delete
Outdated
Show resolved
Hide resolved
wweellddeerr
force-pushed
the
improve-invalid-errata-delete
branch
from
October 9, 2023 19:12
f7d4e19
to
554c489
Compare
mcalmer
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as now everything is green, this looks good
wweellddeerr
force-pushed
the
improve-invalid-errata-delete
branch
from
October 10, 2023 18:31
554c489
to
6b3153d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Context
After a successful patch installation, an update to the server needed cache is scheduled to run, but it takes up to a minute to effectively run and reflect on the WebUI. In this interval, an already installed patch is available for selection, and selecting it at this moment marks it to be installed again. After some seconds, the patch disappear from the screen and there is no chance to remove the it after that, only running a database script.
Changes in this PR:
This PR takes the server id into consideration when removing invalid erratas from
rhnSet
. With that we avoid the situation where the errata is invalid for a server but is in therhnServerNeededErrataCache
because of it is valid for other server.GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: legacy code
DONE
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: