Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where bad scc creds were preventing scc refreshing #7678

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Fix issue where bad scc creds were preventing scc refreshing #7678

merged 5 commits into from
Oct 12, 2023

Conversation

mseidl
Copy link

@mseidl mseidl commented Oct 12, 2023

What does this PR change?

Port already merged in 4.3

Fixes issue when with one bad credential would prevent the other good credential from refreshing.
#21473
https://bugzilla.suse.com/show_bug.cgi?id=1211355

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@mseidl mseidl requested a review from a team as a code owner October 12, 2023 12:50
@mseidl mseidl requested review from mcalmer and removed request for a team October 12, 2023 12:50
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_handle_software_channels_with_ISS_v2
  • allcli_sanity
  • srv_manage_channels_page
  • srv_channels_add
  • srv_sync_products
  • srv_delete_channel_with_tool
  • srv_menu
  • srv_sync_channels
  • srv_content_lifecycle
  • srv_task_status_engine
  • srv_first_settings
  • srv_menu_filter
  • srv_wait_for_reposync
  • allcli_update_activationkeys
  • srv_enable_sync_products
  • srv_create_repository
  • srv_delete_channel_from_ui
  • srv_disable_local_repos_off
  • srv_add_rocky8_repositories
  • srv_channel_api
  • srv_clone_channel_npn

@mseidl mseidl merged commit a91c589 into uyuni-project:master Oct 12, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant