Recognize squashfs build results from kiwi

[aaannz]

What does this PR change?

Our kiwi build inspection was missing squashfs output format. This PR adds recognition of it.

GUI diff

No difference.

• DONE

Documentation

• No documentation needed: only internal and user invisible changes

• DONE

Test coverage

• No tests: integration tests cover for regressions, no unit tests are present

• DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22772
Tracks https://github.com/SUSE/spacewalk/pull/22743

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

[agraul]

The change itself looks good, but I'm questioning the approach of having to a list of known suffixes. Not something we need to fix in this PR, but maybe we can think about it.

I noticed you've put "No tests: already covered" in the PR description. Can you point me to the test case that covers squashfs build results? I'm a bit surprised this is already covered since the changelog entry mentions a bug report.

Please keep in mind that merging this PR will close the Bugzilla-tracking GH issue. You might need to re-open it.

[aaannz]

I don't know about correct key how to select the end image result from the kiwi build. File size is not correct as you can have compressed images which are smaller then original image also present in the build results directory. So we opted for suffixes list and instead of inspecting all possible kiwi results we are doing this per-bug basis as customers needs.

We have tests with regards to overall regressions. It is true that we don't have any squashfs related tests. We don't have any unit tests for this particular code, only integration tests and those tests only KIS images.

[agraul]

I don't know about correct key how to select the end image result from the kiwi build. File size is not correct as you can have compressed images which are smaller then original image also present in the build results directory. So we opted for suffixes list and instead of inspecting all possible kiwi results we are doing this per-bug basis as customers needs.

I see. I haven't used Kiwi much, maybe this is a good way to save time then.

We have tests with regards to overall regressions. It is true that we don't have any squashfs related tests. We don't have any unit tests for this particular code, only integration tests and those tests only KIS images.

The way I see it, test coverage applies to the change and not the component that this change touches. How much work would it be to add tests for "finding the correct artifact"?

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[aaannz]

Still valid, not enough time to focus on this.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[m-czernek]

👍 LGTM, apologies for taking so long.