-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSv3 - Add API to register a peripheral/hub #9611
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
} | ||
|
||
try { | ||
hubManager.storeAccessToken(fqdn, token); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this method should also get a loggedInUser parameter to check it inside of it.
If this method is also called by UI orther code it might be better to perform the user check also in the manager class.
@@ -83,5 +83,41 @@ CREATE TABLE IF NOT EXISTS suseISSAccessToken | |||
expiration_date TIMESTAMPTZ NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as usual we need to check and update the path for the schema migration.
we have "com.suse.manager.iss" and "com.suse.manager.model.hub". |
@mcalmer I think it would be better to have the package as "com.suse.manager.model.hub", since it makes it more flexible in case we need to had more logic to hub scenarios that is not related to ISS |
475f294
to
a69c261
Compare
a69c261
to
23b5567
Compare
What does this PR change?
This PR introduces a new API to register a remote server as a hub or peripheral for the current server. This can be achieved in two ways:
Additionally, the root certificate can be provided if needed to establish a secure connection with the remote server.
API logic
The method will execute the following steps:
Things to develop further
GUI diff
No difference.
Documentation
Test coverage
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25518 https://github.com/SUSE/spacewalk/issues/25519
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!