Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the GH CI after systemd removal from setup scripts. #9671

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jan 23, 2025

What does this PR change?

Mount more files used for the container setup to get the CI pass again.

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested a review from a team as a code owner January 23, 2025 11:00
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9671/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9671/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

srbarrios
srbarrios previously approved these changes Jan 23, 2025
Since more scripts have been changed those need to be mounted. We also
need to start postgresql and ssh as systemd services to emulate the second
container start of a real install.

The setup is also done in a separate container with persisted volumes
like the real container.
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to java/buildconf/ivy/obs-maven-config.yaml LGTM.
...and sorry again for having missed to update the obs-to-maven config

srbarrios
srbarrios previously approved these changes Jan 23, 2025
@srbarrios
Copy link
Member

Almost good! At least now it only fails during the Cucumber tests!
It's an ISE while creating a custom channel, will try to find more info on the logs tomorrow.
Thank you!

CDellaGiusta
CDellaGiusta previously approved these changes Jan 24, 2025
Copy link
Contributor

@CDellaGiusta CDellaGiusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to my limited knowledge of the subject

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search-server/spacewalk-search/buildconf/obs-maven-config.yaml needs to be adapted as well. mybatis is now available in Leap_sle

@mcalmer mcalmer dismissed stale reviews from CDellaGiusta and srbarrios via f329baa January 24, 2025 09:37
@srbarrios srbarrios requested a review from mcalmer January 24, 2025 11:03
@srbarrios srbarrios dismissed mcalmer’s stale review January 24, 2025 11:04

mcalmer already fixed his requested changes.

@deneb-alpha
Copy link
Contributor

approval to merge from @srbarrios and @jordimassaguerpla . bypassing branch protection as org admin

@deneb-alpha deneb-alpha merged commit 0f7ed78 into uyuni-project:master Jan 24, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants