-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the GH CI after systemd removal from setup scripts. #9671
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
5678dcb
to
8e30042
Compare
4d96385
to
ffe2668
Compare
Since more scripts have been changed those need to be mounted. We also need to start postgresql and ssh as systemd services to emulate the second container start of a real install. The setup is also done in a separate container with persisted volumes like the real container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to java/buildconf/ivy/obs-maven-config.yaml
LGTM.
...and sorry again for having missed to update the obs-to-maven config
Almost good! At least now it only fails during the Cucumber tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to my limited knowledge of the subject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search-server/spacewalk-search/buildconf/obs-maven-config.yaml needs to be adapted as well. mybatis is now available in Leap_sle
mcalmer already fixed his requested changes.
approval to merge from @srbarrios and @jordimassaguerpla . bypassing branch protection as org admin |
What does this PR change?
Mount more files used for the container setup to get the CI pass again.
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!