Skip to content

Commit

Permalink
Merge pull request #14 from vaggeliskls/feat/dockerhub
Browse files Browse the repository at this point in the history
Feat/dockerhub
  • Loading branch information
vaggeliskls authored Nov 8, 2024
2 parents ddadda7 + a0cbbce commit 2880353
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
19 changes: 10 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@ on:
release:
types: [published]

# on:
# push:
# branches:
# - qemu-enable

env:
REGISTRY: ghcr.io
TAG_NAME: ${{ github.ref_name }}

jobs:
Expand All @@ -34,7 +28,8 @@ jobs:
with:
# list of Docker images to use as base name for tags
images: |
${{ env.REGISTRY }}/${{ github.repository }}
ghcr.io/${{ github.repository }}
docker.io/${{ github.repository }}
# generate Docker tags based on the following events/attributes
tags: |
type=ref,event=branch
Expand All @@ -50,12 +45,18 @@ jobs:
- name: Login to Github packages
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to Dockerhub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_REGISTRY_USERNAME }}
password: ${{ secrets.DOCKERHUB_REGISTRY_PASSWORD }}

- name: Build and push
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
context: .
file: Dockerfile
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ version: "3.9"

services:
win10:
image: ghcr.io/vaggeliskls/windows-in-docker-container:latest
image: docker.io/vaggeliskls/windows-in-docker-container:latest
env_file: .env
stdin_open: true
tty: true
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "3.9"

services:
win10:
image: ghcr.io/vaggeliskls/windows-in-docker-container:latest
image: docker.io/vaggeliskls/windows-in-docker-container:latest
build:
dockerfile: ./Dockerfile
context: .
Expand Down

0 comments on commit 2880353

Please sign in to comment.