Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrate): added angular 19 support #1285

Merged
merged 3 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
}
]
}
],
"@angular-eslint/prefer-standalone": [
"off"
]
}
},
Expand All @@ -49,7 +52,10 @@
"@typescript-eslint/semi": [
"error"
],
"@typescript-eslint/ban-ts-comment": "off"
"@typescript-eslint/ban-ts-comment": "off",
"@angular-eslint/prefer-standalone": [
"off"
]
}
},
{
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ scripts/**/*.map

.nx/cache
.yarn
.nx/
6 changes: 5 additions & 1 deletion apps/demo/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@
"plugin:@nx/angular",
"plugin:@angular-eslint/template/process-inline-templates"
],
"rules": {}
"rules": {
"@angular-eslint/prefer-standalone": [
"off"
]
}
},
{
"files": [
Expand Down
3 changes: 2 additions & 1 deletion apps/demo/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ const gettingStarted = require('html-loader!markdown-loader!../getting-started.m
<p class="text-muted text-center"><a href="https://github.com/valor-software/ng2-file-upload">ng2-file-upload</a> is maintained by <a href="https://github.com/valor-software">valor-software</a>.</p>
</div>
</footer>
`
`,
standalone: false
})
export class AppComponent {
public gettingStarted:string = gettingStarted;
Expand Down
3 changes: 2 additions & 1 deletion apps/demo/src/app/components/file-upload-section.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const tabDesc: Array<any> = [

@Component({
selector: 'file-upload-section',
templateUrl: './file-upload-section.html'
templateUrl: './file-upload-section.html',
standalone: false
})
export class FileUploadSectionComponent {
name = 'File Upload';
Expand Down
3 changes: 2 additions & 1 deletion apps/demo/src/app/components/file-upload/simple-demo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ const URL = 'https://evening-anchorage-3159.herokuapp.com/api/';

@Component({
selector: 'simple-demo',
templateUrl: './simple-demo.html'
templateUrl: './simple-demo.html',
standalone: false
})
export class SimpleDemoComponent {

Expand Down
4 changes: 2 additions & 2 deletions apps/demo/src/doc.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import { FileSelectDirective, FileDropDirective, FileUploader } from 'ng2-file-u
### Annotations
```typescript
// class FileSelectDirective
@Directive({ selector: '[ng2FileSelect]' })
@Directive({ selector: '[ng2FileSelect]', standalone: false })
```

```typescript
// class FileDropDirective
@Directive({ selector: '[ng2FileDrop]' })
@Directive({ selector: '[ng2FileDrop]', standalone: false })
```

## FileSelect API
Expand Down
6 changes: 5 additions & 1 deletion libs/ng2-file-upload/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@
"plugin:@nx/angular",
"plugin:@angular-eslint/template/process-inline-templates"
],
"rules": {}
"rules": {
"@angular-eslint/prefer-standalone": [
"off"
]
}
},
{
"files": [
Expand Down
2 changes: 1 addition & 1 deletion libs/ng2-file-upload/file-upload/file-drop.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Directive, EventEmitter, ElementRef, HostListener, Input, Output } from

import { FileUploader, FileUploaderOptions } from './file-uploader.class';

@Directive({ selector: '[ng2FileDrop]' })
@Directive({ selector: '[ng2FileDrop]', standalone: false })
export class FileDropDirective {
@Input() uploader?: FileUploader;
@Output() fileOver: EventEmitter<any> = new EventEmitter();
Expand Down
2 changes: 1 addition & 1 deletion libs/ng2-file-upload/file-upload/file-select.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Directive, EventEmitter, ElementRef, Input, HostListener, Output } from

import { FileUploader, FileUploaderOptions } from './file-uploader.class';

@Directive({ selector: '[ng2FileSelect]' })
@Directive({ selector: '[ng2FileSelect]', standalone: false })
export class FileSelectDirective {
@Input() uploader?: FileUploader;
// eslint-disable-next-line @angular-eslint/no-output-on-prefix
Expand Down
2 changes: 0 additions & 2 deletions libs/ng2-file-upload/file-upload/file-upload.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { NgModule } from '@angular/core';

import { FileDropDirective } from './file-drop.directive';
import { FileSelectDirective } from './file-select.directive';
export { FileDropDirective } from './file-drop.directive';
export { FileSelectDirective } from './file-select.directive';

@NgModule({
imports: [ CommonModule ],
Expand Down
6 changes: 3 additions & 3 deletions libs/ng2-file-upload/package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"name": "ng2-file-upload",
"version": "7.0.1",
"version": "8.0.0",
"description": "Angular file uploader",
"author": "Dmitriy Shekhovtsov <[email protected]>",
"license": "MIT",
"peerDependencies": {
"@angular/core": "^18.0.0",
"@angular/common": "^18.0.0"
"@angular/core": "^19.0.0",
"@angular/common": "^19.0.0"
},
"sideEffects": false,
"publishConfig": {
Expand Down
37 changes: 0 additions & 37 deletions migrations.json

This file was deleted.

Loading
Loading