Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): fixed inline datepicker subscriptions #6339

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

SvetlanaMuravlova
Copy link
Contributor

@SvetlanaMuravlova SvetlanaMuravlova commented Oct 29, 2021

fix(datepicker): fixed inline datepicker subscriptions
close #6263

What to test:
In inline datepicker and daterangepicker was fixed subscriptions

Preconditions:
use local version from this branch for reproducing this fix from issue

How to test:
on local version try reproducing as in issue example

@valorkin valorkin temporarily deployed to ngx-bootstra-fix-datepi-91k1qf October 29, 2021 08:46 Inactive
@github-actions
Copy link

github-actions bot commented Oct 29, 2021

Visit the preview URL for this PR (updated for commit b5db1c4):

https://ngx-bootstrap-demo--pr6339-fix-datepicker-subsc-0zv35txm.web.app

(expires Tue, 18 Jan 2022 12:30:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #6339 (b5db1c4) into development (acd560b) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6339      +/-   ##
===============================================
+ Coverage        75.86%   75.91%   +0.05%     
===============================================
  Files              344      315      -29     
  Lines            10777    10638     -139     
  Branches          2547     2933     +386     
===============================================
- Hits              8176     8076     -100     
+ Misses            2591     2561      -30     
+ Partials            10        1       -9     
Impacted Files Coverage Δ
...picker/themes/bs/bs-custom-dates-view.component.ts 60.00% <0.00%> (-20.00%) ⬇️
src/datepicker/utils/bs-calendar-utils.ts 74.68% <0.00%> (-16.75%) ⬇️
src/sortable/sortable.component.ts 5.55% <0.00%> (-13.34%) ⬇️
src/dropdown/bs-dropdown.directive.ts 78.08% <0.00%> (-11.29%) ⬇️
src/tooltip/tooltip.directive.ts 57.04% <0.00%> (-7.30%) ⬇️
src/timepicker/reducer/timepicker.reducer.ts 86.00% <0.00%> (-6.00%) ⬇️
src/pagination/pagination.component.ts 84.37% <0.00%> (-5.23%) ⬇️
src/timepicker/timepicker.component.ts 87.70% <0.00%> (-5.12%) ⬇️
src/modal/modal.directive.ts 4.00% <0.00%> (-4.72%) ⬇️
src/datepicker/bs-datepicker-input.directive.ts 39.39% <0.00%> (-4.36%) ⬇️
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a4b92...b5db1c4. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 29, 2021



Test summary

748 84 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 8e1f193 ℹ️
Started Dec 23, 2021 3:00 PM
Ended Dec 23, 2021 3:37 PM
Duration 37:06 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
dropdowns_page_spec.ts Failed
1 Dropdowns demo page testing suite > Auto close > when user clicks on the first "Button dropdown", then dropdown opened and there are 3 items inside when user press "ESC", then this dropdown closes
2 Dropdowns demo page testing suite > Auto close > when user clicks on the second "Button dropdown", then dropdown opened and there are 3 items inside when user press "ESC", nothing happens
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
3 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
4 Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
5 Modals demo page testing suite: Service examples > Esc closing option > after that click on "Open modal" button, modal popup is opened. when user press ESC button then modal is closed
This comment includes only the first 10 test failures. See all 84 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

apotapcukv
apotapcukv previously approved these changes Oct 29, 2021
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsubscribe should be in all versions I suppose

if (this._subs?.length) {
this._subs.map(sub => sub.unsubscribe());
}
this._subs = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this._subs = [];

@valorkin valorkin merged commit 2e85bac into development Jan 13, 2022
@valorkin valorkin deleted the fix-datepicker-subscriptions branch January 13, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting datesDisabled breaks inline datepicker bsValueChange-Event
3 participants