wip: make the chorus a phaser to see if it sounds better. It kinda do…

…es? TODO: logic to cross-fade between more than 2 effects
vberthiaume · Dec 8, 2024 · dfeb300 · dfeb300
1 parent 5311986
commit dfeb300
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/source/DSP/PhatEffectsProcessor.hpp b/source/DSP/PhatEffectsProcessor.hpp
@@ -30,6 +30,7 @@ enum class EffectType
 {
     verb = 0,
     chorus,
+    // phaser,
     transitioning
 };
 
@@ -159,7 +160,10 @@ class EffectsProcessor
         verbWrapper = std::make_unique<EffectProcessorWrapper<PhatVerbProcessor<T>, T>>();
         verbWrapper->processor.setParameters (reverbParams);
 
-        chorusWrapper = std::make_unique<EffectProcessorWrapper<juce::dsp::Chorus<T>, T>>();
+        // chorusWrapper = std::make_unique<EffectProcessorWrapper<juce::dsp::Chorus<T>, T>>();
+
+        phaserWrapper = std::make_unique<EffectProcessorWrapper<juce::dsp::Phaser<T>, T>>();
+        chorusWrapper = std::make_unique<EffectProcessorWrapper<juce::dsp::Phaser<T>, T>>();
     }
 
     void prepare (const juce::dsp::ProcessSpec& spec)
@@ -170,6 +174,7 @@ class EffectsProcessor
 
         verbWrapper->prepare (spec);
         chorusWrapper->prepare (spec);
+        phaserWrapper->prepare (spec);
         effectCrossFader.prepare (spec);
     }
 
@@ -224,6 +229,7 @@ class EffectsProcessor
             //make the individual blocks and process
             auto audioBlock1 { juce::dsp::AudioBlock<T> (fade_buffer1).getSubBlock ((size_t) startSample, (size_t) numSamples) };
             auto context1 { juce::dsp::ProcessContextReplacing<T> (audioBlock1) };
+            //TODO: this needs to use the current and the next effect
             verbWrapper->process (context1);
 
             auto audioBlock2 { juce::dsp::AudioBlock<T> (fade_buffer2).getSubBlock ((size_t) startSample, (size_t) numSamples) };
@@ -248,7 +254,10 @@ class EffectsProcessor
     }
 
 private:
-    std::unique_ptr<EffectProcessorWrapper<juce::dsp::Chorus<T>, T>> chorusWrapper;
+    // std::unique_ptr<EffectProcessorWrapper<juce::dsp::Chorus<T>, T>> chorusWrapper;
+    std::unique_ptr<EffectProcessorWrapper<juce::dsp::Phaser<T>, T>> chorusWrapper;
+
+    std::unique_ptr<EffectProcessorWrapper<juce::dsp::Phaser<T>, T>> phaserWrapper;
 
     std::unique_ptr<EffectProcessorWrapper<PhatVerbProcessor<T>, T>> verbWrapper;
     PhatVerbParameters reverbParams {

diff --git a/source/DSP/PhatVerb.h b/source/DSP/PhatVerb.h
@@ -276,7 +276,7 @@ class PhatVerb
 };
 
 template <std::floating_point T>
-class PhatVerbProcessor //: PhatProcessorBase<T>
+class PhatVerbProcessor
 {
 public:
     /** Creates an uninitialised Reverb processor. Call prepare() before first use. */