fix(vector): add minReadySeconds to StatefulSet and Deployment specs (#…

…367) * fix(vector): add minReadySeconds to StatefulSet and Deployment specs * fix: minReadySeconds not supported by statefulsets prior to kube v1.22 * feat: use GitVersion instead of Version * fix: update semvercompare comparison to ">=1.22-0" --------- Co-authored-by: Davis Alexander L <[email protected]>
vectordotdev · Feb 15, 2024 · b9e67eb · b9e67eb
1 parent ef5481d
commit b9e67eb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/charts/vector/README.md b/charts/vector/README.md
@@ -164,7 +164,7 @@ helm install --name <RELEASE_NAME> \
 | lifecycle | object | `{}` | Set lifecycle hooks for Vector containers. |
 | livenessProbe | object | `{}` | Override default liveness probe settings. If customConfig is used, requires customConfig.api.enabled to be set to true. |
 | logLevel | string | `"info"` |  |
-| minReadySeconds | int | `0` | Specify the minimum number of seconds a newly spun up DaemonSet pod should wait to pass healthchecks before it is considered available. |
+| minReadySeconds | int | `0` | Specify the minimum number of seconds a newly spun up pod should wait to pass healthchecks before it is considered available. |
 | nameOverride | string | `""` | Override the name of resources. |
 | nodeSelector | object | `{}` | Configure a [nodeSelector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) for Vector Pods. |
 | persistence.accessModes | list | `["ReadWriteOnce"]` | Specifies the accessModes for PersistentVolumeClaims. Valid for the "Aggregator" role. |

diff --git a/charts/vector/templates/deployment.yaml b/charts/vector/templates/deployment.yaml
@@ -14,6 +14,7 @@ spec:
   selector:
     matchLabels:
       {{- include "vector.selectorLabels" . | nindent 6 }}
+  minReadySeconds: {{ .Values.minReadySeconds }}
   {{- with .Values.updateStrategy }}
   strategy:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/vector/templates/statefulset.yaml b/charts/vector/templates/statefulset.yaml
@@ -15,6 +15,9 @@ spec:
   selector:
     matchLabels:
       {{- include "vector.selectorLabels" . | nindent 6 }}
+  {{- if semverCompare ">=1.22-0" .Capabilities.KubeVersion.GitVersion }}
+  minReadySeconds: {{ .Values.minReadySeconds }}
+  {{- end }}
   {{- with .Values.updateStrategy }}
   updateStrategy:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/vector/values.yaml b/charts/vector/values.yaml
@@ -186,7 +186,7 @@ lifecycle: {}
   #     - "10"
 
 
-# minReadySeconds -- Specify the minimum number of seconds a newly spun up DaemonSet pod should wait to
+# minReadySeconds -- Specify the minimum number of seconds a newly spun up pod should wait to
 # pass healthchecks before it is considered available.
 minReadySeconds: 0