feat(build): support Apple silicon (ARM) #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jszwedko
reviewed
Jan 10, 2025
| on_macos do | ||
| on_intel do | ||
| url "https://packages.timber.io/vector/0.43.1/vector-0.43.1-x86_64-apple-darwin.tar.gz" | ||
| sha256 "x86_64_SHA256_HASH_PLACEHOLDER" # x86_64-apple-darwin |
There was a problem hiding this comment.
Just FYI this'll need to be updated to a static value. This static value is updated by the tooling in Vector: https://github.com/vectordotdev/vector/blob/master/vdev/src/commands/release/homebrew.rs
There was a problem hiding this comment.
Does this mean replacing "https://packages.timber.io/vector/0.43.1/vector-0.43.1-x86_64-apple-darwin.tar.gz" with VERSION_PLACEHOLDER?
There was a problem hiding this comment.
Ah, sorry, I mean well want to replace the sha256 line with something like sha256 <actual SHA> after the v0.44.0 release publishes the new artifacts and we can calculate the SHAs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be tested after v0.44.0 is published.
Ref: vectordotdev/vector#10193