Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Project Discovery fixes #50

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

NinjaLikesCheez
Copy link
Collaborator

This change addresses some issues with workspace project discovery:

  • Use a new data structures to simplify logic
  • Change behaviour to account for the parent group's path, and not the entire ancestory
  • Add a test app (tests to come)

@NinjaLikesCheez NinjaLikesCheez self-assigned this Oct 20, 2023
@NinjaLikesCheez NinjaLikesCheez marked this pull request as draft October 20, 2023 12:20
@NinjaLikesCheez NinjaLikesCheez changed the base branch from main to unstable October 20, 2023 12:27
@NinjaLikesCheez NinjaLikesCheez changed the base branch from unstable to main October 23, 2023 11:44
@NinjaLikesCheez NinjaLikesCheez marked this pull request as ready for review November 30, 2023 14:03
@NinjaLikesCheez NinjaLikesCheez changed the title Draft: Workspace Project Discovery fixes Workspace Project Discovery fixes Nov 30, 2023
@NinjaLikesCheez NinjaLikesCheez changed the base branch from main to develop December 1, 2023 09:31
Rewrite workspace project discovery to break it up into more sensible & logical pieces.
Add a test asset (test to come).

The biggest change is that the group naming only follows the nearest group parent - not all of them
@NinjaLikesCheez NinjaLikesCheez force-pushed the workspace-container-fixes branch from 98ca442 to 4dfefaf Compare December 1, 2023 09:46
@NinjaLikesCheez
Copy link
Collaborator Author

Periphery installing is broken in the workflows for some reason - will address at some point in the future.

@NinjaLikesCheez NinjaLikesCheez merged commit 783daa5 into develop Dec 1, 2023
2 of 3 checks passed
@NinjaLikesCheez NinjaLikesCheez deleted the workspace-container-fixes branch December 1, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups in workspace with paths relative to container: not being handled
1 participant