Handle targets with same name but in different projects #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmxav
force-pushed
the
project-specific-targets
branch
from
5d21b81 to
451a5f6
Compare
NinjaLikesCheez
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for multiple projects to contain the same target name, but we only track targets in the build log by the target name. Because of this we will see duplicated bitcode files across all targets with the same name. The solution implemented here is to track targets by both project name and target name in the build log as we do not have access to GUIDs there. We then use these names to map back to the appropriate PIF targets.
The challenge is pulling the name of the project since it is not necessarily present in the PIF files, so we fallback to using the name of the root group node in the project. I am not sure this is the 100% correct way to go, but I can't think of anything better at the moment.
Fixes #46