Append offset to subpaths output by vg chunk -p #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlifying context expansion meant losing path ranks. Proper support of subpaths is still pending: vgteam/libhandlegraph#29.
This PR hacks context expansion (but only activates in vg chunk) to append a suffix with the subpath offset for subpaths. If missing edges implied by paths are behind tube map crashes, as suspected in #2504, then this should be a fix.
Todo: should this be on by default (as opposed to just in chunk?) Is it worth supporting more generally, or should we just wait for a better API?