-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 + updated dependencies #120
base: main
Are you sure you want to change the base?
Conversation
[moved to issue] |
#!/usr/bin/env bash | ||
FILE=$(readlink "$0" || echo "$0") | ||
DIR=$(dirname $FILE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be done in a more POSIX compatible way with:
#!/usr/bin/env sh
DIR="$(CDPATH= cd -- "$(dirname -- "$0")" && pwd -P)"
While readlink tends to be available on GNU, Busybox, & BSD/OS X systems, it's non-standard & flags differ between them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch.
Thanks for this!!
|
FWIW, the appimage this builds dumps core on my Arch install. Something packaging-related (missing Would be a good idea to switch to pypi's Which brings me to my main point -- think I've managed to fix the Windows build by updating Vial's configuration to match fbs's current defaults (plus a few extras). I'll bang on it for a week to see if anything breaks and then submit a PR to your branch with details.
Google tells me this may be a |
Update requirements to 2022-08-08
Create easy runner command for linux/mac
Update readme