RSDK-9610 - reconnect loop should exit if it fails #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+435
to
+437
| if not self._connected: | ||
| # We failed to reconnect, sys.exit() so that this thread doesn't stick around forever. | ||
| sys.exit() |
There was a problem hiding this comment.
Does this mean that it will exit if it fails to reconnect once? I remember I did some work a few years ago that had to do with supporting reconnect attempts, so wanted to make sure this was something separate.
There was a problem hiding this comment.
I have since expanded the code above this. 😅 LGTM!
purplenicole730
approved these changes
Jan 7, 2025
Comment on lines
+435
to
+437
| if not self._connected: | ||
| # We failed to reconnect, sys.exit() so that this thread doesn't stick around forever. | ||
| sys.exit() |
There was a problem hiding this comment.
I have since expanded the code above this. 😅 LGTM!
njooma
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes the
_check_connectionmethod to callsys.exit()if it reaches the end of the reconnect loop and remains disconnected. Without doing so, it remains alive and attempting to reconnect forever whenever RDK quits non-gracefully, causing a memory leak.Returning is not sufficient, because the thread still exists and remains managed, so the server's await on process closing never returns. By exiting, the parent module recognizes that its processes have completed and shuts down successfully.
Tested locally by having RDK shutdown with exit code 1 abruptly. With this change, the python module exits once the reconnect loop completes. Without this change, the python module stays alive indefinitely until
killed.