-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests on ephemeral ports #2081
Conversation
- for obvious reasons - dropped IPv6 binds as requestHTTP to IPv6 addresses doesn't work (vibe-d#2080) (also IPv6 support should be tested once, not everywhere)
7e9fe51
to
2de64a0
Compare
Yeah, just a recent example: https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fdmd/detail/PR-7939/5/pipeline
Though there seems to be something wrong with vibe-core and the older libevent driver:
(all libasync jobs pass) I tried to reproduce this locally, but failed. |
The libasync runs pass only because the high level tests are not executed. The tcpproxy example is just missing an explicit "127.0.0.1" bind address (as well as some others maybe). |
It's weird that listenTCP returns an IPv6 listener with addr 0 on Travis-CI which doesn't have IPv6 enabled (filed as #2083). I've added a workaround and filtered the listeners for an IPv4 one. |
Please rerun or ignore this job https://travis-ci.org/vibe-d/vibe.d/jobs/345425216. |
Especially given that some tests like
@s-ludwig any chance @MartinNowak can be added to team? |
Sent an invitation |
That surprised me as well, the API is a bit weird, apparently it does listen on all interfaces and for IPv4 and IPv6 separately if you don't specify an address.
|
Yeah, I'd really like to deprecate this and the |
I disagree. Binding to all available interfaces makes more sense than binding to the 127.0.0.1. |
(also IPv6 support should be tested once, not everywhere)