Fix scope related deprecation warnings in vibe.data.json #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
fix_json_scope_warnings
branch
2 times, most recently
from
259fe09 to
b420620
Compare
Geod24
reviewed
Jun 25, 2023
| void put(char ch) @trusted { sink((&ch)[0 .. 1]); } | ||
| } | ||
| auto r = DummyRangeS(sink); | ||
| writeJsonString(r, this); | ||
| } | ||
| /// ditto | ||
| void toString(scope void delegate(const(char)[]) @system sink, FormatSpec!char fmt) | ||
| void toString(scope void delegate(scope const(char)[]) @system sink, FormatSpec!char fmt) |
There was a problem hiding this comment.
That's a breaking change isn't it ? Giving it a non-scope delegate will break.
There was a problem hiding this comment.
True, I'll add a separate overload. Not sure what the warning here was anyway, at least the method should be @system.
Avoids using formattedWrite directly in order to avoid warnings when passing a scope output range. Also marks the `line` parameter of `parseJson` `scope` (which probably isn't inferred as such due to the recursive nature of `parseJson`).
s-ludwig
force-pushed
the
fix_json_scope_warnings
branch
from
b420620 to
0cbfba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids using formattedWrite directly in order to avoid warnings when passing a scope output range.
Also marks the
lineparameter ofparseJsonscope(which probably isn't inferred as such due to the recursive nature ofparseJson).See also #2724.