Updates hono-entry.node.ts
to serve static files from public directory
#452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
As mentioned in the issue, project with Hono doesn't serve static files that they put to the
public/
directory.After some investigation, turns out that in
hono-entry.node.ts
there are these lines:Because of these lines, Vike app files are served correctly, because they are in
./dist/client/assets/
directory, but if I had file underpublic/logo.svg
, during build it will be copied to./dist/client/logo.svg
and Hono lacks routing rule for that.This PR changes pattern from
assets/*
to just/*
, it matches both cases, so that all files from the public directory start serving normally as well as/assets
dir is resolved