Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'pat_vim2py' table to pycompiler.vim #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move 'pat_vim2py' table to pycompiler.vim #142

wants to merge 1 commit into from

Conversation

tyru
Copy link
Member

@tyru tyru commented Aug 7, 2019

After #141

Embed converted regexp pattern to py/vimlparser.py.
This minor fix improves below a little.

  • shrink file size of py/vimlparser.py
  • performance

@tyru tyru force-pushed the move-pat_vim2py-table branch from bbfe973 to a1870cb Compare August 7, 2019 08:32
@tyru tyru requested review from blueyed and mattn August 7, 2019 08:37
@tyru tyru force-pushed the move-pat_vim2py-table branch from a1870cb to 7d0baf5 Compare August 12, 2019 01:28
@tyru
Copy link
Member Author

tyru commented Aug 12, 2019

rebased.

@blueyed
Copy link
Contributor

blueyed commented Aug 12, 2019

Would be good to have this rebased after #146.
I did #146 initially since I wanted to see if the changed code here is covered.

@tyru tyru force-pushed the move-pat_vim2py-table branch from 7d0baf5 to 3564605 Compare August 12, 2019 02:15
@tyru
Copy link
Member Author

tyru commented Aug 12, 2019

rebased again :)

@blueyed blueyed closed this Aug 12, 2019
@blueyed blueyed reopened this Aug 12, 2019
@blueyed
Copy link
Contributor

blueyed commented Aug 12, 2019 •
edited
Loading

close-reopen for codecov.

There appears to be an issue with them.
Looks ok from https://codecov.io/gh/vim-jp/vim-vimlparser/commit/356460528c14390b6eb7e88f3d1c70afa894d1af - but let's wait for it a bit.

@blueyed blueyed closed this Aug 13, 2019
@blueyed blueyed reopened this Aug 13, 2019
@blueyed blueyed closed this Sep 27, 2019
@blueyed blueyed reopened this Sep 27, 2019
@tyru tyru mentioned this pull request Mar 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed Awaiting requested review from blueyed

@mattn mattn Awaiting requested review from mattn

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyru @blueyed