Develop #1
Open
Develop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshumishra31
force-pushed
the
develop
branch
2 times, most recently
from
0ebc8d7 to
06b3529
Compare
himanshumishra31
force-pushed
the
develop
branch
from
06b3529 to
ad383a9
Compare
himanshumishra31
force-pushed
the
develop
branch
from
9e0964d to
ad97b3b
Compare
himanshumishra31
force-pushed
the
develop
branch
from
ad97b3b to
9e5f5e5
Compare
Added the link to the Youtube video.
Update README.md
sent-hil
reviewed
Mar 1, 2019
| @@ -3,4 +3,16 @@ | |||
| # | |||
| # Example adding this to your spec_helper will load these Factories for use: | |||
| # require 'spree_one_page_stock_management/factories' | |||
| factory :stock_updater, class: Spree::StockUpdater do | |||
| data_file { File.new(Rails.root + 'lib/test.csv') } | |||
There was a problem hiding this comment.
hi, i think you forgot to include this and the below files in the PR; we want to use gem and it would be great if you included this so the tests pass
thanks!
There was a problem hiding this comment.
Hi @sent-hil
All the test files have been added. Thanks for notifying.
…-management into develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.