Skip to content

Commit

Permalink
Actually run CI linting with nightly (#274)
Browse files Browse the repository at this point in the history
Previously the rust linting workflow downloaded nightly but didn't use it. This made the CI `fmt` checks to generate warnings since we use nightly `rustfmt` configs.
  • Loading branch information
JoseSK999 authored Nov 8, 2024
1 parent 68c43df commit fc09d0e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
uses: Swatinem/rust-cache@v2

- name: Run cargo fmt
run: cargo fmt --all --check
run: cargo +nightly fmt --all --check

- name: Run cargo clippy
run: cargo clippy --all-targets
run: cargo +nightly clippy --all-targets
env:
PWD: ${{ github.workspace }} # without it ci can't see env!("PWD")

Expand Down
2 changes: 1 addition & 1 deletion .rustfmt.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ newline_style = "Unix"
format_code_in_doc_comments = true

# macros
format_macro_matchers = true
format_macro_matchers = true
2 changes: 1 addition & 1 deletion rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[toolchain]
channel = "1.74.1"
components = [ "rustfmt", "clippy" ]
profile = "default"
profile = "default"

0 comments on commit fc09d0e

Please sign in to comment.