WIP: Feature/task 743 add external lib #1082
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1082 +/- ##
=================================================
- Coverage 86.70% 86.69% -0.02%
Complexity 5018 5018
=================================================
Files 606 606
Lines 25196 25196
Branches 2264 2264
=================================================
- Hits 21847 21844 -3
- Misses 2579 2584 +5
+ Partials 770 768 -2
|
There was a problem hiding this comment.
I think, this may become a highly complicated integration.
I suggest that we do the Java 11 and Eclipse 2022-03 migration first, before going back to this PR.
I see the point of the external lib for LYO, but i think we shoiuld be careful with choosing dependencies, since a lot of dependencies are already provided by our external libs for the jersey integration. We may need to clean up here, otherwise we might end up in running to many different versions in parralel.
Another point is the use of Jena which is not clear to me. I also question if it needs to be separated into an individuel external lib plugin.
The About.htmls are not correctly adjusted in all cases. They all state a third paryt dependency to Apache POI, this has to be cleaned up.
I suggest, that we discuss the integration in one of our next developer meetings, so that everyone is aware of these upcoming changes.
| @@ -0,0 +1,23 @@ | |||
| Apache POI | |||
| Lists of 64 third-party dependencies. | ||
| (Apache 2.0) Jackson-annotations (com.fasterxml.jackson.core:jackson-annotations:2.10.1 - http://github.com/FasterXML/jackson) | ||
| (Apache 2.0) Jackson-core (com.fasterxml.jackson.core:jackson-core:2.10.1 - https://github.com/FasterXML/jackson-core) | ||
| (Apache 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.10.1 - http://github.com/FasterXML/jackson) |
There was a problem hiding this comment.
Jackson dependencies are already introduced via the external lib jersey. should check if we need them here again, or if we have to externalize it.
| The following third party libraries are directly included into this plugin using maven. | ||
| Transitive dependency information is given at the end of the page. | ||
|
|
||
| <h5>Apache POI - Version 3.17</h5> |
There was a problem hiding this comment.
Apache POI should not be mentioned here. Please update the descriptions of the dependencies.
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <artifactId>apache-jena-libs</artifactId> |
There was a problem hiding this comment.
In case we need jena, it should be considered to be an external library by itself.
| The following third party libraries are directly included into this plugin using maven. | ||
| Transitive dependency information is given at the end of the page. | ||
|
|
||
| <h5>Apache POI - Version 3.17</h5> |
There was a problem hiding this comment.
This one should state something about Mockito
PhilMFischer
changed the title
Added required external libs for Doors synchronization process
Linked to #743