Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format numbers with a sensible number of digits when setting wcs #1915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomjnixon
Copy link

This mainly affected setting the work coordinate with the mouse, which can result in numbers with lots of digits. This doesn't work with my particular controller (uCNC), but more generally always results in a very long command being shown in the UI, and is inconsistent with other code.

This does make some uses of _wcsSet look a bit odd:

  • some places pass '"0"' strings (or empty strings), presumably to avoid being formatted as "0.0", but this is redundant if they are always converted to a float first.
  • some places round numbers before calling this, but that's not necessary.

I can fix these if desired. It's also unclear what the 10000mm limit is for; looks like this was introduced in this commit d8dbd63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant