Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added initial aria-label for bigPlay component #115

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

chz
Copy link
Contributor

@chz chz commented Dec 4, 2023

This PR contains a: bigPlay button doesn't have initial aria-label="Play". It will only added when user clicked play or pause. but must have.

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vlite ✅ Ready (Inspect) Visit Preview Dec 4, 2023 9:24pm

Copy link
Member

@yoriiis yoriiis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chz for the contribution

@yoriiis yoriiis enabled auto-merge December 4, 2023 21:39
@yoriiis yoriiis disabled auto-merge December 4, 2023 21:39
@yoriiis yoriiis merged commit 1f57d5f into vlitejs:main Dec 4, 2023
11 of 12 checks passed
@chz chz deleted the fix/big-play-aria-label branch December 5, 2023 22:24
@chz
Copy link
Contributor Author

chz commented Dec 5, 2023

@yoriiis please also update npm package

@yoriiis
Copy link
Member

yoriiis commented Dec 7, 2023

@chz The fix is available in the 6.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants