Fix the destroy method #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello @tadaskarpavicius, thanks for your feedback! Interesting, indeed, the changes are potentially breaking and I don't want to make a major release with just that for the moment. I can add a parameter (disabled by default) to the "destroy" function that does this behaviour. Tell me what you think |
destroy() method should remove all traces of the plugin and restore the media element to its original state. At the moment it just removes the container element (with video element itself) which is not an expected behavior
|
@tadaskarpavicius Still relevant today? |
|
Closing due to inactivity. Thanks! Feel free to reopen if relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
destroy() method should remove all traces of the plugin and restore the media element to its original state.
At the moment it just removes the container element (with video element itself) which is not an expected behavior
Breaking Changes
Potentially breaking in those cases where users expected such destroy() behavior and wrote code which interacts with outerContainer after destroy method was called
Additional Info